After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634156 - gnome-appearance-properties erases backgrounds.xml if Backgrounds tab is not shown before closing
gnome-appearance-properties erases backgrounds.xml if Backgrounds tab is not ...
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 636548 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-06 10:58 UTC by Pacho Ramos
Modified: 2011-09-09 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-control-center-2.32.0-background-xml-write.patch (1.85 KB, patch)
2010-11-06 10:58 UTC, Pacho Ramos
none Details | Review

Description Pacho Ramos 2010-11-06 10:58:54 UTC
Created attachment 173940 [details] [review]
gnome-control-center-2.32.0-background-xml-write.patch

1. Open gnome-terminal and run "gnome-appearance-properties"
2. go to "background" tab
3. Click on "Add" and add a new image from my home.
4. Click on "Close"
5. Run again "gnome-appearance-properties"
6. Click on close without opening "Background" tab

Now check ~/.gnome2/backgrounds.xml:

<?xml version="1.0"?>
<!DOCTYPE wallpapers SYSTEM "gnome-wp-list.dtd">
<wallpapers/>

Attached patch from:
http://bugs.gentoo.org/show_bug.cgi?id=344335

and prepared by Matthew Turnbull looks to solve this. 

Thanks for fixing this
Comment 1 Michał Buczeluk 2011-01-09 14:36:08 UTC
I can confirm this bug in 2.32.1. Given patch seems to fix the issue. One note: in step 3: add either 2 or more wallpapers or after adding only one, select other wallpaper or none. Selected one will not disappear even though backgrounds.xml will be empty. gnome-appearance-properties probably reads currently used wallpaper from gconf settings in /desktop/gnome/background at startup etc.
Comment 2 Bastien Nocera 2011-02-12 03:27:53 UTC
Reassigning to "Appearance" for GNOME 2.x, the GNOME 3 code doesn't save anything anymore.
Comment 3 Jean-François Fortin Tam 2011-02-12 13:51:49 UTC
*** Bug 636548 has been marked as a duplicate of this bug. ***
Comment 4 Pacho Ramos 2011-02-24 18:07:32 UTC
Attached patch worked ok for me, if there won't be "Appearance" in gnome-control-center-3, maybe this could be committed only to 2.32 branch... Thanks
Comment 5 Pacho Ramos 2011-03-13 18:09:03 UTC
Could you at least review the patch and tell us if it's safe enough to be included downstream? Thanks
Comment 6 Bastien Nocera 2011-03-14 14:07:05 UTC
(In reply to comment #5)
> Could you at least review the patch and tell us if it's safe enough to be
> included downstream? Thanks

Sorry, but you should ask somebody who's familiar with the GNOME 2.32.x capplet. I've never read its code, I only triaged the bugs.
Comment 7 Pacho Ramos 2011-03-14 20:53:43 UTC
OK, I hope any other gnome-control-center developer will also read this :-)
Regards
Comment 8 Bastien Nocera 2011-09-09 10:12:08 UTC
Nobody cares about GNOME 2.32 it seems, not even the people shipping it. Closing this.