GNOME Bugzilla – Bug 634153
use c-symbol-prefix where possible for method pairing
Last modified: 2015-02-07 16:57:38 UTC
Currently, for method pairing to work, the method names have to start with the value returned by utils.to_underscores_noprefix(name).lower(), but the more capital letters in the type name, the less likely it is that the names will match. For example, in rhythmbox, we have "RBMetaData" as a type, and methods on it are named "rb_metadata_*", but utils.to_underscores_prefix("MetaData") returns "meta_data", so none of the methods get paired. There are a few other similar cases too. In each case in rhythmbox, the method prefixes match that of the _get_type function, so checking that instead (or in addition?) to the result of to_underscores_prefix() seems like a good idea.
Created attachment 173938 [details] [review] use target.c_symbol_prefix where possible This makes me about 300% happier with the generated introspection data for rhythmbox.
Review of attachment 173938 [details] [review]: Makes sense; can you add a regression test?
There's one there already, actually - regress_test_wi_802_1x_{get,set}_testbool are currently represented as static methods in Regress-1.0-expected.gir when they should really be instance methods.
Created attachment 174383 [details] [review] update expected Regress-1.0.gir Not sure what's going on with test_unichar here.. was it added in the wrong place?
Review of attachment 174383 [details] [review]: Please commit, thanks!
pushed as commit 52d0020.
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]