After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634104 - media-keys: Port to GDBus
media-keys: Port to GDBus
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 622871
 
 
Reported: 2010-11-05 17:46 UTC by Bastien Nocera
Modified: 2010-11-06 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Port to GDBus (12.42 KB, patch)
2010-11-05 17:46 UTC, Bastien Nocera 		none Details | Review
media-keys: Port to GDBus (14.18 KB, patch)
2010-11-05 18:22 UTC, Bastien Nocera 		none Details | Review
media-keys: Port to GDBus (20.75 KB, patch)
2010-11-06 17:37 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2010-11-05 17:46:31 UTC 
First pass, can't seem to get the methods called in test-media-keys though.
Comment 1 Bastien Nocera 2010-11-05 17:46:42 UTC 
Created attachment 173898 [details] [review]
media-keys: Port to GDBus

So that we can actually track the clients at some point...
Comment 2 Bastien Nocera 2010-11-05 18:22:46 UTC 
Created attachment 173905 [details] [review]
media-keys: Port to GDBus

So that we can actually track the clients at some point.
Comment 3 Bastien Nocera 2010-11-05 18:25:03 UTC 
Comment on attachment 173898 [details] [review]
media-keys: Port to GDBus

The new patch fixes:
- wrong known name being used (this means that you'll need to shut down gsd to test the media keys)
- fix parsing of args for registration
- fix signal emission, it's not bound to signal emission on the GObject anymore

Seems to work well in my testing.
Comment 4 Bastien Nocera 2010-11-06 17:37:42 UTC 
Created attachment 173961 [details] [review]
media-keys: Port to GDBus

And track clients, so that applications don't need to call
ReleaseMediaPlayerKeys when exiting. This also fixes problems
when application exit ungracefully.
Comment 5 Bastien Nocera 2010-11-06 17:53:09 UTC 
Attachment 173961 [details] pushed as c94a4d1 - media-keys: Port to GDBus