Bug 634088 – Uses uninitialized variable in action_contact_new_cb

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 634088 - Uses uninitialized variable in action_contact_new_cb


Summary:	Uses uninitialized variable in action_contact_new_cb


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Contacts
Version:	2.32.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Milan Crha
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2010-11-05 14:58 UTC by Milan Crha
Modified:	2010-11-05 15:38 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
evo patch (481 bytes, patch) 2010-11-05 15:34 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2010-11-05 14:58:42 UTC

Moving from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=650190

abrt version: 1.1.13
architecture: x86_64
Attached file: backtrace
cmdline: evolution calendar:///?startdate=20101112T050000Z
component: evolution
crash_function: action_contact_new_cb
executable: /usr/bin/evolution
kernel: 2.6.35.6-48.fc14.x86_64
package: evolution-2.32.0-2.fc14
rating: 4
reason: Process /usr/bin/evolution was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
time: 1288965558
uid: 500

How to reproduce
-----
1. I was entering my schedule on evolution
2. I clicked on add contact for the very first time and it crashed

Core was generated by `evolution calendar:///?startdate=20101112T050000Z'.
Program terminated with signal 11, Segmentation fault.

+ Trace 224513

Thread 1 (Thread 3210)

#0 action_contact_new_cb
at e-book-shell-backend.c line 249
#1 g_closure_invoke
at gclosure.c line 766
#2 signal_emit_unlocked_R
at gsignal.c line 3252
#3 g_signal_emit_valist
at gsignal.c line 2983
#4 g_signal_emit
at gsignal.c line 3040
#5 _gtk_action_emit_activate
at gtkaction.c line 794
#6 g_closure_invoke
at gclosure.c line 766
#7 signal_emit_unlocked_R
at gsignal.c line 3182
#8 g_signal_emit_valist
at gsignal.c line 2983
#9 g_signal_emit
at gsignal.c line 3040
#10 IA__gtk_widget_activate
at gtkwidget.c line 5023
#11 IA__gtk_menu_shell_activate_item
at gtkmenushell.c line 1283
#12 gtk_menu_shell_button_release
at gtkmenushell.c line 710
#13 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 86
#14 g_closure_invoke
at gclosure.c line 766
#15 signal_emit_unlocked_R
at gsignal.c line 3290
#16 g_signal_emit_valist
at gsignal.c line 2993
#17 g_signal_emit
at gsignal.c line 3040
#18 gtk_widget_event_internal
at gtkwidget.c line 4992
#19 IA__gtk_propagate_event
at gtkmain.c line 2460
#20 IA__gtk_main_do_event
at gtkmain.c line 1665
#21 gdk_event_dispatch
at gdkevents-x11.c line 2377
#22 g_main_dispatch
at gmain.c line 2149
#23 g_main_context_dispatch
at gmain.c line 2702
#24 g_main_context_iterate
at gmain.c line 2780
#25 g_main_loop_run
at gmain.c line 2988
#26 IA__gtk_main
at gtkmain.c line 1237
#27 main
at main.c line 671

Comment 1 Milan Crha 2010-11-05 15:34:46 UTC

Created attachment 173886 [details] [review]
evo patch

for evolution;

Confirming, I can reproduce this too. it's a crash due to used uninitialized memory. The patch is pretty simple.

Comment 2 Milan Crha 2010-11-05 15:38:19 UTC

Created commit 17da811 in evo master (2.91.2+)
Created commit fc2624a in evo gnome-2-32 (2.32.1+)