After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634060 - Support for GIcon pixbufs
Support for GIcon pixbufs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 634059
Blocks:
 
 
Reported: 2010-11-05 09:49 UTC by Cosimo Cecchi
Modified: 2010-11-05 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon-theme: support pixbufs implementing the GIcon interface (2.28 KB, patch)
2010-11-05 09:50 UTC, Cosimo Cecchi 		committed Details | Review
tests: add a test for pixbufs implementing the GIcon interface (4.39 KB, patch)
2010-11-05 09:51 UTC, Cosimo Cecchi 		committed Details | Review
icon-theme: always force icon sizes for emblems (1.08 KB, patch)
2010-11-05 09:51 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2010-11-05 09:49:22 UTC 
In bug 634059 I proposed that GdkPixbuf should implement GIcon.
Attached some patches to integrate that with GtkIconTheme/GtkIconInfo (and a test).
Comment 1 Cosimo Cecchi 2010-11-05 09:50:57 UTC 
Created attachment 173870 [details] [review]
icon-theme: support pixbufs implementing the GIcon interface
Comment 2 Cosimo Cecchi 2010-11-05 09:51:01 UTC 
Created attachment 173871 [details] [review]
tests: add a test for pixbufs implementing the GIcon interface
Comment 3 Cosimo Cecchi 2010-11-05 09:51:04 UTC 
Created attachment 173872 [details] [review]
icon-theme: always force icon sizes for emblems
Comment 4 Cosimo Cecchi 2010-11-05 09:58:37 UTC 
Note that the last patch could probably be applied anyway, as it fixes inconsistencies when handling the emblem size (this is visible e.g. in nautilus, see [1]).

[1] http://people.gnome.org/~cosimoc/emblems.png
Comment 5 Matthias Clasen 2010-11-05 15:02:11 UTC 
Looks good to me, please apply. I guess we don't need to bump the gdk-pixbuf dep, since we will simply never see a gicon that is a pixbuf, with the current versin.
Comment 6 Cosimo Cecchi 2010-11-05 15:26:57 UTC 
Attachment 173870 [details] pushed as 5071aa7 - icon-theme: support pixbufs implementing the GIcon interface
Attachment 173871 [details] pushed as fcfd494 - tests: add a test for pixbufs implementing the GIcon interface
Attachment 173872 [details] pushed as a994a9f - icon-theme: always force icon sizes for emblems