After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634014 - GTK+3 is a moving target, lets not compile against it by default.
GTK+3 is a moving target, lets not compile against it by default.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-04 18:30 UTC by Olivier Crête
Modified: 2010-11-06 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: Only compile against GTK+3 if explicitly requested (1.58 KB, patch)
2010-11-04 18:31 UTC, Olivier Crête
none Details | Review
configure: Only compile against GTK+3 if explicitly requested (1.12 KB, patch)
2010-11-04 18:32 UTC, Olivier Crête
none Details | Review
configure: Only compile against GTK+3 if explicitly requested (1.11 KB, patch)
2010-11-04 18:32 UTC, Olivier Crête
none Details | Review

Description Olivier Crête 2010-11-04 18:30:11 UTC
At least on Fedora 14, the gtk+3 in there doesn't actually let me compile the gst examples/tests, so I guess its safer to not enable it by default until a version with a stable API is released.
Comment 1 Olivier Crête 2010-11-04 18:31:44 UTC
Created attachment 173838 [details] [review]
configure: Only compile against GTK+3 if explicitly requested
Comment 2 Olivier Crête 2010-11-04 18:32:33 UTC
Created attachment 173839 [details] [review]
configure: Only compile against GTK+3 if explicitly requested
Comment 3 Olivier Crête 2010-11-04 18:32:53 UTC
Created attachment 173840 [details] [review]
configure: Only compile against GTK+3 if explicitly requested
Comment 4 Olivier Crête 2010-11-04 18:34:49 UTC
arg, the first one is against base, the second is for good and the 3rd is for bad
Comment 5 Benjamin Otte (Company) 2010-11-04 21:18:20 UTC
I do think that's a good idea for GStreamer, as compilation of examples is not something that GTK developers care about a lot.

If I were picky, I'd suggest using the code that's copied around in gnome-land, which does:

AC_MSG_CHECKING([which gtk+ version to compile against])
AC_ARG_WITH([gtk],
  AC_HELP_STRING([--with-gtk=3.0|2.0],
                 [which gtk+ version to compile against (default: 3.0)]),
  [case "$with_gtk" in
      2.0|3.0) ;;
      *) AC_MSG_ERROR([invalid gtk+ version specified]);;
  esac],
  [with_gtk=3.0])
AC_MSG_RESULT([$with_gtk])

but I'll leave that to the build system maintainer(s).
Comment 6 Olivier Crête 2010-11-04 21:34:27 UTC
I copied the one I used from empathy.. the --with-gtk=X also looks fine (as long as 2.0 is the default at least until gtk+ 3 is stabilized).
Comment 7 Tim-Philipp Müller 2010-11-06 12:41:30 UTC
I went with the --with-gtk option now, since I slightly prefer that. Hope it all still works right now. Thanks for the bug report and patches.