GNOME Bugzilla – Bug 633918
[fakesink] [PATCH] print sink-message events like a message and its structure
Last modified: 2010-12-03 08:29:02 UTC
Created attachment 173786 [details] [review] print sink-message events like a message and it's structure sink-message events are supposed to be treated like messages by sinks. In this case print them like a message and the message's structure
Review of attachment 173786 [details] [review]: Good idea. I can push after the small detail got fixed and git is open for commits. ::: plugins/elements/gstfakesink.c @@ +414,2 @@ + if (!g_strcmp0 ("sink-message", str_name)) { + GstMessage *msg; wouldn't it be better to do GST_EVENT_TYPE(event)==GST_EVENT_SINK_MESSAGE?
Review of attachment 173786 [details] [review]: Of course :)
Created attachment 174121 [details] [review] 0001-fakesink-Print-sink-message-events-like-a-message-an.patch Make use of "GST_EVENT_TYPE (event) == GST_EVENT_SINK_MESSAGE" as suggested in previous comment
Created attachment 174122 [details] [review] 0001-fakesink-Print-sink-message-events-like-a-message-an.patch I attached the wrong file in the previous commit
Comment on attachment 174122 [details] [review] 0001-fakesink-Print-sink-message-events-like-a-message-an.patch Looks good now. I'll push this after freeze.