After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633764 - DAP: Fix transcoding of files without profiles
DAP: Fix transcoding of files without profiles
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-02 01:45 UTC by Michał Sawicz
Modified: 2010-11-07 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
DAP: Fix transcoding of files without profiles (1.59 KB, patch)
2010-11-02 01:45 UTC, Michał Sawicz 		needs-work Details | Review
DAP: Fix transcoding of files without profiles (1.73 KB, patch)
2010-11-02 02:02 UTC, Michał Sawicz 		committed Details | Review

Description Michał Sawicz 2010-11-02 01:45:39 UTC 
When a source file to be transferred to a DAP did not match any
available profile, it was not transcoded due to the fact that the
extension returned was null and many in AcceptableMimeTypes for a
device suffered the same. In that case null == null and no transcoding
was performed.
Comment 1 Michał Sawicz 2010-11-02 01:45:43 UTC 
Created attachment 173664 [details] [review]
DAP: Fix transcoding of files without profiles

When a source file to be transferred to a DAP did not match any
available profile, it was not transcoded due to the fact that the
extension returned was null and many in AcceptableMimeTypes for a
device suffered the same. In that case null == null and no transcoding
was performed.
Comment 2 Gabriel Burt 2010-11-02 01:49:18 UTC 
Review of attachment 173664 [details] [review]:

::: src/Dap/Banshee.Dap/Banshee.Dap/DapSource.cs
@@ +339,3 @@
         {
             foreach (string mimetype in AcceptableMimeTypes) {
+                string extension = ServiceManager.MediaProfileManager.GetExtensionForMimeType (track.MimeType);

Let's move this above the foreach, and then we can avoid the foreach entirely if extension == null.
Comment 3 Michał Sawicz 2010-11-02 02:02:42 UTC 
Created attachment 173665 [details] [review]
DAP: Fix transcoding of files without profiles

When a source file to be transferred to a DAP did not match any
available profile, it was not transcoded due to the fact that the
extension returned was null and many in AcceptableMimeTypes for a
device suffered the same. In that case null == null and no transcoding
was performed.
Comment 4 Gabriel Burt 2010-11-07 22:56:45 UTC 
Review of attachment 173665 [details] [review]:

Committed, thanks