After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633667 - No feedback on volume change from panel
No feedback on volume change from panel
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-01 01:59 UTC by Jonathan Strander
Modified: 2011-02-17 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
VolumeStatus: play notification on scroll (3.48 KB, patch)
2011-02-15 18:27 UTC, Giovanni Campagna
committed Details | Review

Description Jonathan Strander 2010-11-01 01:59:53 UTC
Hovering over the sound icon on the panel and using the mouse wheel allows you to change the current volume. There's no indication of the current volume however (besides a rough guess based on the icon shifting states) unless you have actually clicked the icon and opened the menu.
Comment 1 Florian Müllner 2010-11-01 12:10:59 UTC
(In reply to comment #0)
> There's no indication of the current volume however 
> (besides a rough guess based on the icon shifting states)

Except of course for the actual volume change :-)
Comment 2 Giovanni Campagna 2010-11-01 12:14:54 UTC
Yes, and this is no different than current volume control applet.
We can't play the volume-change beep, because we don't know when you are okay with scrolling, unless we add a small timeout and ignore scroll-events that are within that timeout.
Comment 3 Jonathan Strander 2010-11-01 19:17:05 UTC
And what happens(In reply to comment #1)
> (In reply to comment #0)
> > There's no indication of the current volume however 
> > (besides a rough guess based on the icon shifting states)
> 
> Except of course for the actual volume change :-)


And what happens when you are trying to change the volume BEFORE performing an action. What's wrong with a stronger visual indication?

It's worse because you may have changed the volume without realizing you were doing so.
Comment 4 Jonathan Strander 2010-11-19 00:57:03 UTC
Suggestion: Pop up the volume popup-menu with a timeout.
Comment 5 Bastien Nocera 2011-02-09 00:32:35 UTC
I don't think there's anything wrong with launching a new sound event for each wheel event, as long as you cancel the previous sound. That's what the handling for the media keys does (play a sound on each key press).
Comment 6 Giovanni Campagna 2011-02-15 18:27:50 UTC
Created attachment 180930 [details] [review]
VolumeStatus: play notification on scroll

Add the machinery to cancel the notification when a new playing a
new one (wrapping ca_context_cancel), then use it when scrolling
the status icon.
Not doing it for the slider because it causes noise, either with the
keyboard, with mouse drag or with mouse wheel.
Comment 7 drago01 2011-02-17 13:04:03 UTC
Review of attachment 180930 [details] [review]:

Looks good and from a quick testing it seems to be indeed an improvement (and consistent with the volume hotkeys).
Comment 8 Giovanni Campagna 2011-02-17 14:37:43 UTC
Attachment 180930 [details] pushed as a1e019b - VolumeStatus: play notification on scroll

This problem has been fixed in the development version. The fix will be available
in the next major software release. Thank you for your bug report.