After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633591 - Fix cursor image tracking on 64-bit systems
Fix cursor image tracking on 64-bit systems
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Dan Winship
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-30 21:30 UTC by Owen Taylor
Modified: 2010-11-01 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix cursor image tracking on 64-bit systems (2.48 KB, patch)
2010-10-30 21:30 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-10-30 21:30:47 UTC 
Like all X API, XFixesGetCursorImage returns arrays of 32-bit
quantities as arrays of long; on 64-bit systems we need to
convert to an array of 32-bit words before creating a texture
from the result.
Comment 1 Owen Taylor 2010-10-30 21:30:49 UTC 
Created attachment 173576 [details] [review]
Fix cursor image tracking on 64-bit systems
Comment 2 Dan Winship 2010-11-01 13:45:13 UTC 
Comment on attachment 173576 [details] [review]
Fix cursor image tracking on 64-bit systems

we should fix shell-recorder to use shell-xfixes-cursor too rather than having this code in two places...
Comment 3 Owen Taylor 2010-11-01 15:15:04 UTC 
(In reply to comment #2)
> (From update of attachment 173576 [details] [review])
> we should fix shell-recorder to use shell-xfixes-cursor too rather than having
> this code in two places...

Don't think that's really easy - one needs a CoglTexture (vram), one a cairo_image (system ram)- we could try to share the fetching code so we don't fetch it twice on every change when there is a magnifier and a recorder active, but I suspect it would be a net increase of LOC for a rare situation. (Yes, we wouldn't need to work around this issue twice...)
Comment 4 Owen Taylor 2010-11-01 15:15:37 UTC 
Attachment 173576 [details] pushed as 909ec7a - Fix cursor image tracking on 64-bit systems