GNOME Bugzilla – Bug 633555
discoverer: use specific types in getters, rename some boolean getters
Last modified: 2010-11-01 11:06:44 UTC
Created attachment 173557 [details] [review] pbutils: update for discoverer API changes in last gst-plugins-base pre-release +++ This bug was initially created as a clone of Bug #633311 +++ Use GstDiscoverer{Audio,Video}Info in getters like gst_discoverer_{audio,video}_info_get_*(). This avoids the casts in the macros, help language bindings and is more correct. Also rename _get_is_image() to _is_image() and _get_interlaced() to _is_interlaced().
Note: not tested at all really. (Also, unrelated, 'make check' fails for me in gst-python/testsuite/test_bin.py", line 174, in testFake.)
I've pushed this, since it breaks e.g. pitivi and the patch reportedly fixes that: <thiblahute> Hello, I just recompiled gstreamer using jhbuild (I got some issue with gst-plugin-bad and had to desactivate -Werror), and am trying to launch pitivi now, but am getting: Traceback (most recent call last):
+ Trace 224414
_run_pitivi()
import pitivi.application as ptv
from pitivi.ui.mainwindow import PitiviMainWindow
import gst.pbutils
Any idea what is wrong? <__tim> thiblahute, the API was changed in gst-plugins-base git, gst-python git needs updating for that <__tim> thiblahute, https://bugzilla.gnome.org/show_bug.cgi?id=633555 <thiblahute> __tim: Ok, I am going to have a look at it then. <thiblahute> __tim: Works perfectly with the patch, is it closed to be applied? commit 366f1650a510faf6d80f7d856432d4c839196ae2 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sat Oct 30 16:18:59 2010 +0100 pbutils: update for discoverer API changes in last gst-plugins-base pre-release https://bugzilla.gnome.org/show_bug.cgi?id=633311