GNOME Bugzilla – Bug 633552
AAC Files converted to MP3 even though iPod supports AAC
Last modified: 2011-04-08 17:52:56 UTC
The summary says it all, really. I got around to trying the iPod support in Banshee 1.8 today, and found out that it wanted to convert ALL of my AAC files to MP3 when synching the library. As a former iTunes user, I have a fair amount of music in AAC format, so this would have taken forever. For me, it's back to gtkpod until this is fixed.
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. The intend is to have this fixed in the very near future, pending review for correctness of the AAC gstreamer pipeline used in the AAC profile. *** This bug has been marked as a duplicate of bug 612741 ***
David, I think you misread the bug. Ryan's issue is basically that Banshee doesn't think his iPod supports AAC (when it does) so it tries to transcode his tracks. It should just transfer them -- the bug has nothing to do with whether there's an AAC encoder profile available.
I think that we need to do a custom IDeviceMediaCapabilities class for iPhones. the default Gio/Udev implementation uses device-media-info which is for USB mass storage devices.
Ryan are you using an iphone or ipod, and can you post a link to the file of an offending song?
I'm using an iPod Classic, 80 GB. I've uploaded an AAC encoding of a MOD file I made a while ago. It's freely available, so I'd say it's a safe choice. http://dl.dropbox.com/u/8445226/Quantum%203.m4a
Err, that didn't come out quite right. I made the encoding, not the song. The original is from http://modarchive.org/index.php?request=view_by_moduleid&query=52854
Can you please post the contents of /usr/share/media-player-info/apple-1261_1262.mpi
That file doesn't exist on my system. I ran a locate on media-player-info and on apple-1261 and found neither.
Hey that might be part of the problem. What distro are you using? Can you install the media-player-info package?
I am running Xubuntu 10.10, with the Banshee team daily build archive (https://launchpad.net/~banshee-team/+archive/banshee-daily) in my PPA. I am installing the media-player-info package now. I will let you know how it works out. Note that I checked the dependencies in Synaptic and the ONLY package that depends on media-player-info is rhythmbox. If the iPod support requires it to function properly, I think it needs to be added as a dependency of the banshee package. I will wipe my iPod, try it out in Banshee again, and get back to you.
I just filed a bug, and a patch against the Debian banshee package to depend on media-player-info, because it should.
Ah, this is an interesting bug since it's related to what is discussed at http://article.gmane.org/gmane.comp.ipod.gtkpod/4815 and in rhythmbox bug #634140 Basically, some libgpod API to report audio formats supported by the ipod is being added, but I'd need to know if the suggested format is appropriate for banshee or not.
Okay, I tried it again with the media-player-info package and the problem went away. I'll leave it to you guys to decide to either make that required, or use the libgpod API as suggested by Christophe.
Created attachment 177363 [details] [review] Adds m4a to the acceptable mime types for Apple devices
Christophe, I like the idea of using libgpod to determine formats the device understands. In the meantime, we could use something like my proposed patch to enable Apple devices to use m4a files without transcoding.
Created attachment 177364 [details] [review] Adds m4a to the acceptable mime types for Apple devices (without trace) Removed the trace the previous patch had.
Really we should just add a dep on media-player-info. The Ubuntu package should have already been updated.
For Apple devices you would also need to add mp4 and m4v to the acceptable mime types. Right now banshee just fails silently to copy those files. Would the media-player-info also fix this bug?
I installed the media-player-info from my distro's repositories, but it still refused to copy the m4a file. Contents of the relevant media-player-info file: $ cat /usr/share/media-player-info/apple_0x1261_0x1262.mpi [Device] Product=iPods with video Vendor=Apple DeviceMatch=usb:05ac:1261;usb:05ac:1262 AccessProtocol=storage;ipod [Media] OutputFormats=audio/mpeg;audio/aac;audio/x-wav;audio/x-aiff;video/mp4
This doesn't just happen for Apple devices btw. http://www.omgubuntu.co.uk/2011/01/banshee-doesnt-show-android-fix/?utm_source=feedburner&utm_medium=feed&utm_campaign=Feed%3A+d0od+%28Omg%21+Ubuntu%21%29#comment-128211394
Just wondering if there is a work-around for this while we're waiting for a bugfix? Just to confirm, I've got the issue with Ipod-Touch. Confirmed I have the latest media-player-info package installed. I'm on Fedora 14 running Banshee 1.8.1, (installed via official repo).
Comment on attachment 177364 [details] [review] Adds m4a to the acceptable mime types for Apple devices (without trace) I committed a similar workaround, also ensuring mp3 is supported. Pushed to master and stable-2.0 branches.