Created attachment 217091 [details] [review]
documents: add support for Google Drawings

Add a GDataDocumentsDocument subclass to handle drawing docs.

Review of attachment 217091 [details] [review]:

This looks good, but a few minor things are missing.

The main SECTION documentation comment in gdata-documents-document.c needs updating to mention GDataDocumentsDrawing. Similarly, the documentation comment for GDataDocumentsEntry:resource-id also needs updating.

Code to handle drawings needs to be added to gdata_documents_service_finish_upload().

Once these are fixed, please commit to master. Thanks!

::: gdata/services/documents/gdata-documents-drawing.c
@@ +3,3 @@
+ * GData Client
+ * Copyright (C) Thibault Saunier 2009 <saunierthibault@gmail.com>
+ * Copyright (C) Philip Withnall 2010 <philip@tecnocode.co.uk>

You should probably add your name to the copyright.

@@ +30,3 @@
+ * <ulink type="http" url="https://developers.google.com/google-apps/documents-list/">online documentation</ulink>.
+ *
+ * Since: 0.13.2

This should be 0.13.1 (libgdata uses post-release version increments, and 0.13.1 hasn’t been released yet).

Created attachment 217201 [details] [review]
documents: add support for Google Drawings

---

Thanks Philip, I fixed your review comments in this updated patch.

Review of attachment 217201 [details] [review]:

Great! Please commit to master.

Attachment 217201 [details] pushed as 09d594d - documents: add support for Google Drawings