After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633435 - resident notifications emit ActionInvoked multiple times when updated
resident notifications emit ActionInvoked multiple times when updated
Status: RESOLVED FIXED
Product: notification-daemon
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-10-29 07:13 UTC by Jonathan Matthew
Modified: 2010-10-29 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
only attach signal handlers when creating a new notification (1.35 KB, patch)
2010-10-29 07:14 UTC, Jonathan Matthew 		none Details | Review

Description Jonathan Matthew 2010-10-29 07:13:30 UTC 
handle_notify() connects the closed and action-invoked signal handlers every time, rather than just when creating the notification, so if you have a notification that gets updated multiple times, you end up with duplicate ActionInvoked dbus signals when an action is invoked.
Comment 1 Jonathan Matthew 2010-10-29 07:14:23 UTC 
Created attachment 173465 [details] [review]
only attach signal handlers when creating a new notification
Comment 2 William Jon McCann 2010-10-29 20:06:33 UTC 
Oops.  Nice catch.  Pushed with the tabs removed.  Thanks!