Created attachment 173451 [details]
The log of the failing build process.

I forgot to attach the log. :)

Created attachment 173474 [details] [review]
gnome-shell-build-setup.sh: add libcanberra-devel for volume control

my bad. mutter uses canberra so I assumed we were already pulling it in
somehow, but apparently mutter only uses it *optionally*

(ftr, from a quick check there don't appear to be any more optional
dependencies left in mutter that we aren't explicitly requiring)

Review of attachment 173474 [details] [review]:

Looks fine, I've been sort of trying to keep things alphabetized in the deps lists, but since they already are not alphabetized, it's sort of a weak "try".

If the canberra dep in mutter wasn't optional, we'd need to build libcanberra, since what we need there is libcanbera-gtk3

Comment on attachment 173474 [details] [review]
gnome-shell-build-setup.sh: add libcanberra-devel for volume control

we're going to need git libcanberra-gtk3 for the deps of the new status icons anyway

Created attachment 173637 [details] [review]
gnome-shell.modules: add libcanberra

The volume status icon requires libcanberra; we could get by with
packages so far, but we will need a very very recent libcanberra soon
anyway, so just require that.

(Extracted from a patch from Giovanni Campagna in bug 622451.)

Created attachment 173638 [details] [review]
gnome-shell.modules: add libcanberra

use libcanberra 0.26

Review of attachment 173638 [details] [review]:

Assuming that you've tested that it builds, looks good. (I ask only because I have a poor track record of detecting issues with moduleset additions by inspection.)

Attachment 173638 [details] pushed as 79a33fa - gnome-shell.modules: add libcanberra