After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633350 - g_hostname_to_ascii() ignores non-ascii dots
g_hostname_to_ascii() ignores non-ascii dots
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-10-28 13:52 UTC by Carlos Garcia Campos
Modified: 2010-12-15 08:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ghostutils: Convert non-ASCII dots to '.' when converting hostnames (7.40 KB, patch)
2010-12-10 10:45 UTC, Dan Winship
committed Details | Review

Description Carlos Garcia Campos 2010-10-28 13:52:17 UTC
In rfc3490 section 3.1:

" Whenever dots are used as label separators, the following
      characters MUST be recognized as dots: U+002E (full stop), U+3002
      (ideographic full stop), U+FF0E (fullwidth full stop), U+FF61
      (halfwidth ideographic full stop)."

so, for example the url "www.foo\u3002bar.com" should be "www.foo.bar.com" not "www.xn--foobar-rr3e.com"

I've tried it with ICU and Qt and both work, see:

http://source.icu-project.org/repos/icu/icu/trunk/source/common/uidna.cpp
http://qt.gitorious.org/qt/qt/blobs/4.5/src/corelib/io/qurl.cpp#line5546
Comment 1 Dan Winship 2010-12-10 10:45:53 UTC
Created attachment 176171 [details] [review]
ghostutils: Convert non-ASCII dots to '.' when converting hostnames

Can you see if the webkit tests pass with this patch?
Comment 2 Carlos Garcia Campos 2010-12-13 12:53:42 UTC
Yes, it fixes the non-ASCII dots test case, thanks!
Comment 3 Dan Winship 2010-12-15 08:59:50 UTC
Attachment 176171 [details] pushed as 7ee902a - ghostutils: Convert non-ASCII dots to '.' when converting hostnames