After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633330 - gvfs client code on arm platform stops working after first connection to daemon
gvfs client code on arm platform stops working after first connection to daemon
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
1.6.x
Other Linux
: High major
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-28 08:10 UTC by Henry Hoegelow
Modified: 2010-12-07 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
changes signature of async_connection_accept_new_fd to return gboolean (654 bytes, patch)
2010-10-28 08:10 UTC, Henry Hoegelow 		none Details | Review
fix return value of async_connection_accept_new_fd() (1.46 KB, patch)
2010-11-25 21:43 UTC, Sven Neumann 		committed Details | Review

Description Henry Hoegelow 2010-10-28 08:10:12 UTC 
Created attachment 173383 [details] [review]
changes signature of async_connection_accept_new_fd to return gboolean

After the first connection between a GInputStream and the gvfsd, all subsequent attempts fail. This was seen on ARM hardware only.
The reason is, that in gvfsdaemonbus.c the GSourceFunc returns 'void' where a 'gboolean' return value is expected. So if accidentally a zero value is returned, the source function will be removed.
Comment 1 Sven Neumann 2010-11-25 21:43:03 UTC 
Created attachment 175280 [details] [review]
fix return value of async_connection_accept_new_fd()

Patch with proper indentation reformatted as git commit.
Comment 2 Sven Neumann 2010-11-25 21:45:16 UTC 
Raising priority as this bug makes gvfs pretty much unusable on platforms where the value returned on the stack happens to be 0. Please consider to get this into the next 1.6 release.
Comment 3 Bastien Nocera 2010-12-07 14:03:03 UTC 
Review of attachment 175280 [details] [review]:

Please commit to the various branches affected.
Comment 4 Sven Neumann 2010-12-07 19:37:03 UTC 
Committed to master and gnome-2-32.