After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633269 - GtkTreeView inline search broken for gnome-session-properties (patch)
GtkTreeView inline search broken for gnome-session-properties (patch)
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session-properties
git master
Other Linux
: Normal minor
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-27 14:21 UTC by Ricardo Cruz
Modified: 2010-12-01 00:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Search column fix (patch) (2.30 KB, patch)
2010-10-27 14:21 UTC, Ricardo Cruz
committed Details | Review

Description Ricardo Cruz 2010-10-27 14:21:25 UTC
Created attachment 173327 [details] [review]
Search column fix (patch)

Greetings,

Currently, you can't do an inline search on the GtkTreeView of the gnome-session-properties configuration tool.

The line in question:
    gtk_tree_view_set_search_column (treeview, STORE_COL_DESCRIPTION);

The problem is that the attribute being specified is a markup string, of the form: "<b>Program Name</b>\nDescription". The user has to start his search with "<b>" in order to find the line he wants!

In my patch, I add another attribute (I called it STORE_COL_APP_NAME), that keeps strings of whatever term is contained in that "Program Name", and change the search_column to that attribute.

(In retrospect, maybe STORE_COL_SEARCH would be a better name for the attribute, given it is only used for that purpose.)

Note: it's a very simple patch, so I haven't bother testing it, given I don't have the dependencies in order on my system. It should work, but please do give it a try before committing it. ;)
Comment 1 Vincent Untz 2010-11-29 21:42:45 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Ricardo Cruz 2010-12-01 00:48:59 UTC
Vincent, as I said, I didn't try the git version, but I did look at the code. And I very much doubt it's fixed. ;-) My simple patch should fix it though. (it's attached in the description comment.)
Comment 3 Ricardo Cruz 2010-12-01 00:51:02 UTC
Oh, wait. You're saying you've committed the fix, right?

Okay, ignore my comment then. And thanks for addressing the bug report btw!