After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633215 - Remove deprecated GDK symbols from NoteEditor
Remove deprecated GDK symbols from NoteEditor
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-26 20:00 UTC by Aurimas Černius
Modified: 2011-05-09 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the bug. (2.12 KB, patch)
2010-10-26 20:00 UTC, Aurimas Černius 		none Details | Review
Updated, added end key handling. (2.12 KB, patch)
2010-10-28 19:46 UTC, Aurimas Černius 		none Details | Review

Description Aurimas Černius 2010-10-26 20:00:45 UTC 
Created attachment 173283 [details] [review]
Patch to fix the bug.

GDK key constants have a KEY_ prefix from now and will be such in GTK+ 3.0.
This patch replaces the old deprecated constants with new ones.

I didn't commit them, because I couldn't quickly find the GTK+ version, since when they are supported. Does anyone knows it?
Comment 1 Hubert Figuiere (:hub) 2010-10-28 04:12:52 UTC 
See http://git.gnome.org/browse/gtk+/commit/?id=913cdf3be750a1e74c09b20edf55a57f9a919fcc

"For C application compatiblity, add gdkkeysyms-compat.h which uses the old names. "


I'd rather stick to that for now. To avoid Gtk 3.0 only changes.
Comment 2 Aurimas Černius 2010-10-28 19:46:02 UTC 
Created attachment 173429 [details] [review]
Updated, added end key handling.

Updated accordingly to bug 633217.
This can wait for a while, until we decide to upgrade to GTK+ 3.0.
Comment 3 Aurimas Černius 2011-05-09 19:48:43 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.