GNOME Bugzilla – Bug 633194
[at-spi2-atk] Add configuration for GTK modules
Last modified: 2010-12-16 00:26:20 UTC
As done in at-spi
Created attachment 173262 [details] [review] Add configuration for GTK modules
Just a question about this patch. As far as I see this just add a .desktop file, and place it in the proper gsettings module directory. But as far as I understood the change on bug 633191, not only the desktop files would be moved to $(libdir)/gnome-settings-daemon-3.0/gtk-modules/, it is also required to move there the modules itself. So I think that this patch still requires to modify atk-adaptor/gtk-3.0/Makefile.am, that has this code: if RELOCATE gtkmoduledir = $(libdir)/gtk-3.0/modules/at-spi-dbus/modules else gtkmoduledir = $(libdir)/gtk-3.0/modules endif In order to move to gnome-settings-daemon-3.0 directory. And probably it would be also required to think again the relocation thing. This is right? Other possibility is that this bug is just about the configuration (.desktop) file, and the placement of the modules should be managed on other bug. If this is the case, sorry for the noise.
(In reply to comment #2) > Just a question about this patch. > > As far as I see this just add a .desktop file, and place it in the proper > gsettings module directory. > > But as far as I understood the change on bug 633191, not only the desktop files > would be moved to $(libdir)/gnome-settings-daemon-3.0/gtk-modules/, it is also > required to move there the modules itself. No it doesn't. You only need to install the .desktop file, it replaces the GConf schemas, that's all.
(In reply to comment #3) > (In reply to comment #2) > > But as far as I understood the change on bug 633191, not only the desktop files > > would be moved to $(libdir)/gnome-settings-daemon-3.0/gtk-modules/, it is also > > required to move there the modules itself. > > No it doesn't. You only need to install the .desktop file, it replaces the > GConf schemas, that's all. Ok, thanks for the explanation.
Review of attachment 173262 [details] [review]: We'll need to update the Makefile to install the module in the right place, as Alejandro suggested, but this patch looks fine. Sorry for the delay.
(In reply to comment #5) > Review of attachment 173262 [details] [review]: > > We'll need to update the Makefile to install the module in the right place, as > Alejandro suggested, but this patch looks fine. Sorry for the delay. Mike take a look to Bastien explanation on comment 3. For gtk sake, it would not required to change where the modules are placed. This bug is just about the .desktop file. After Bastien explanation I took a look to the code, and this is just that the settings daemon uses this .desktop file to know which modules load. But it would be gtk code the one that will load the modules, as the settings daemon will warn the apps. So if the bridge is located in the gtk module directory, it should be loaded without problems. Finally (and somewhat off-topic), just to comment here again, that it would be good to think a little the placement of the atk-bridge, because technically it is not a "pure gtk module" as can be used for any complaint atk toolkit like clutter. This affects how gnome-shell loads atk-bridge [1], as it is not clear how to locate it [2] [1] https://bugzilla.gnome.org/show_bug.cgi?id=612599 [2] https://bugs.freedesktop.org/show_bug.cgi?id=28580
I've committed the patch. I'm not seeing a way to mark the bug resolved; I suspect I don't have permission.
Done, thanks. Could you add a link to the gitweb/cgit for the patch?