GNOME Bugzilla – Bug 633147
Simple reverse negotiation pipeline is broken.
Last modified: 2010-10-29 12:54:58 UTC
gst-launch videotestsrc ! videoscale ! ffmpegcolorspace ! ximagesink no longer reverse negotiates correctly. Enlarging the window displays the video at the original size, with black borders. Reverting f8abf35000570a8afe64268b430e998e2d735e61 fixes it: commit f8abf35000570a8afe64268b430e998e2d735e61 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Thu Aug 26 15:12:49 2010 +0200 basetransform: recover from invalid downstream suggestions When we are handling a buffer and need to allocate an output buffer, handle the case when downstream suggests us a format that we can't convert the input buffer to. In that case, check if there is another format available downstream instead of failing. Fixes #621332 and see also #614296
Created attachment 173333 [details] [review] possible patch
The patch fixes it for me, and doesn't seem to break anything, so yay!
I'll try to write a testcase for this later
Comment on attachment 173333 [details] [review] possible patch Test case would be nice indeed :)
Created attachment 173415 [details] [review] videoscale: Add unit test for working reverse negotiation See bug #633147.
commit ce919c0573a492baeeb57fff414f7f0fa42dfd69 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Thu Oct 28 13:29:31 2010 +0100 basetransform: fix reverse negotiation When the downstream element suggests a new format, pass the suggestion upstream if we can't convert to it. Fixes #633147
Comment on attachment 173415 [details] [review] videoscale: Add unit test for working reverse negotiation Awesome, please push this as well.