GNOME Bugzilla – Bug 633098
crash due to "Folder can not be copied recursively" in PodcastService initialization
Last modified: 2020-03-17 09:01:14 UTC
Created attachment 173171 [details] Log of the error When i try to start banshee, it opens: i can she the interface for 1 second, after this it crashes down. I allready tried to reinstall it, but it didn't help. (sry for my bad english)
Ok, can you please post your music lib path and your podcast path. XDG_MUSIC_DIR which mean I guess: /home/MyUser/Music/Podcasts become $XDG_PODCASTS_DIR/Podcasts which mean I guess /home/MyUser/Podcasts Can you check if env var XDG_MUSIC_DIR & XDG_PODCASTS_DIR exists? If yes can you post dir. I think one is include inside other. Because Banshee test if path are equal but do not test if contain. I mean move from /mypath/ to /mypath/subfolder/ and reverse must work. I think fix is in Banshee.IO to test if folder contain other or not. If folder contain other, a solution is rename folder with a temp name. build destination folder and after move data to final destination. FYI, error come from glib: http://git.gnome.org/browse/glib/tree/gio/gfile.c I wait your feedback and made patch if I am right...
Created attachment 173216 [details] [review] Patch1 to test if fix the issue can you test that?
I'm not sure if i understand, what you excatly wanna know: my whole music is stored in: /media/multimedia/Musik/ ?
what is your env var for XDG_MUSIC_DIR & XDG_PODCASTS_DIR? where is put your podcasts?
how can i find this out, because i can't start banshee to have a look into the preferences...? i don't know if it's the same in rhytmbox - there it is same as for the whole music: /media/multimedia/Musik/ did this help?
hit echo $XDG_MUSIC_DIR in a terminal/console. and echo $XDG_PODCASTS_DIR Have you got a podcasts folder in /media/multimedia/Musik/ ?
benjy@BJAbig:~$ echo $XDG_MUSIC_DIR benjy@BJAbig:~$ echo $XDG_PODCASTS_DIR benjy@BJAbig:~$ When i type this in, nothing appears.... But yes, there is a podcast folder in /media/multimedia/Musik/
Anyway can you get last source and apply my patch to see if it solve the issue?
*** Bug 631071 has been marked as a duplicate of this bug. ***
Workaround from the duplicate : Create a Podcasts folder in your home folder (mkdir ~/Podcasts). Banshee should then start without crashing.
benjy@BJAbig:~/Desktop$ patch -p0 < patch.txt patching file b/src/Extensions/Banshee.Podcasting/Banshee.Podcasting/PodcastService.cs Hunk #1 FAILED at 254. 1 out of 1 hunk FAILED -- saving rejects to file b/src/Extensions/Banshee.Podcasting/Banshee.Podcasting/PodcastService.cs.rej benjy@BJAbig:~/Desktop$ i'm not sure, if i applied your patch in the right way?
(In reply to comment #10) > Workaround from the duplicate : > > Create a Podcasts folder in your home folder (mkdir ~/Podcasts). Banshee should > then start without crashing. thanks! this solved my problem.
ok so that was not an issue about recursing but about missing folder. Exception report with wrong sentence... So my patch was wrong just have to create folder if not exists...
The exception message is a bit misleading, here's the problem : We try to move the old Podcasts folder which used to be in the music library folder to the new location : <music library>/Podcasts -> ~/Podcasts If the music library is on a different filesystem, the GIO backend cannot do a real move and falls back to copy+delete. But the copy operation cannot copy a directory structure, so it spits out the "Can't recursively copy directory" error. See the GIO docs : http://library.gnome.org/devel/gio/stable/GFile.html#g-file-move http://library.gnome.org/devel/gio/stable/GFile.html#g-file-copy This works fine with other IO backends. I'll try to find a fix in the GIO backend, suggestions welcome !
Review of attachment 173216 [details] [review]: I don't think the patch addresses the issue in this bug (see my previous comment). The situation you're testing should never happen : new_path is always ~/Podcasts.
I ever understand that do not addresses the issue when I see that exception sentence was misleading. Anyway, thanks for the review.
*** Bug 633660 has been marked as a duplicate of this bug. ***
*** Bug 649096 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.