After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633089 - typo in gtkcombo.c leads to gtk-warning
typo in gtkcombo.c leads to gtk-warning
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.23.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-10-25 10:12 UTC by Nicolas Setton
Modified: 2010-12-22 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against git branch gtk-2.23.0 (410 bytes, patch)
2010-10-25 10:12 UTC, Nicolas Setton 		none Details | Review

Description Nicolas Setton 2010-10-25 10:12:25 UTC 
Created attachment 173161 [details] [review]
patch against git branch gtk-2.23.0

A small typo introduced in 6271cb96:


-----------------------------------------------
  @@ -666,7 +666,7 @@ gtk_combo_popup_button_press (GtkWidget        *button,
   popup_grab_on_window (combo->popwin->window,
                        gtk_get_current_event_time ());
 
-  gtk_button_pressed (GTK_BUTTON (button));
+  g_signal_emit_by_name (button, "depressed");
 
   gtk_grab_add (combo->popwin);
----------------------------------------------- 


"depressed" should be "pressed". 

This causes a gtk-warning when clicking on the button on the old gtkcombo widgets, and potential unwanted behavior as callbacks to the "pressed" signal are no longer being called.

Patch against 2.23.x attached.