After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633059 - f-spot-import script umounts unnecessarily gphoto2 mounts
f-spot-import script umounts unnecessarily gphoto2 mounts
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Import
0.8.0
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-24 21:29 UTC by Christian Krause
Modified: 2010-11-14 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to simplify f-spot-import (1.33 KB, patch)
2010-10-24 21:29 UTC, Christian Krause
committed Details | Review

Description Christian Krause 2010-10-24 21:29:21 UTC
Created attachment 173140 [details] [review]
patch to simplify f-spot-import

the current f-spot-import script umounts certain gphoto2 mounts:

e.g.

if [ "$udi" != "${udi#gphoto2:}" ]; then
	# gphoto2, as passed by gvfs/nautilus
	gvfs-mount -u "$udi" || true
	f-spot --import "$udi"
	exit
fi

Since f-spot 0.8.0 only supports importing via file system URIs I suggest to remove all umounting features from this script. Patch attached. I have tested it with nautilus-2.32.0. I'm not sure what kind of other call conventions are used in other environments.
Comment 1 Ruben Vermeersch 2010-11-14 11:03:44 UTC
Merged, let's see what this gives.