After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632941 - calendar ignores preference "show/hide end times"
calendar ignores preference "show/hide end times"
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-10-22 22:46 UTC by Oliver Joos
Modified: 2011-01-02 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (838 bytes, patch)
2010-11-02 08:38 UTC, Milan Crha
committed Details | Review

Description Oliver Joos 2010-10-22 22:46:46 UTC
I tested evolution 2.28.3-0 (Ubuntu Lucid), 2.30.3-1 (Ubuntu Maverick) and 2.32.0-2-fc14 (pre-release of fedora 14) - all these are affected.

To reproduce:
1. Open evolution with Calendar view
2. Open menu Edit - Preferences - Calendar and Tasks - Display
3. Toggle checkbox "Show appointment end times in week and month view"
=> No change in week or month view. Closing Preferences window or restarting evolution does not help.

In 2.28.3-0 this preference does not show/hide end times but "am/pm" and alarm
icons! Whereas printing the calendar never shows end times - see https://launchpad.net/bugs/587425
Comment 1 Oliver Joos 2010-10-24 09:19:06 UTC
I just tested Fedora 13. evolution 2.30.3-1.fc13 is also affected.

In Week view and List view the end times are always shown. Day, Work Week and Month view never show them.
Comment 2 Milan Crha 2010-11-02 08:37:51 UTC
Thanks for a bug report. The initial launchpad bug is about something totally different, about printing single event, that it doesn't show start and end times at all in the print out. This particular issue was addressed in bug #618102.

But I see also your issue, thus confirming.
Comment 3 Milan Crha 2010-11-02 08:38:50 UTC
Created attachment 173681 [details] [review]
evo patch

for evolution;

There was a little typo in the code.
Comment 4 Milan Crha 2010-11-02 08:44:39 UTC
Created commit 870ab18 in evo master (2.91.2+)
Created commit b7f26a2 in evo gnome-2-32 (2.32.1+)
Comment 5 Oliver Joos 2010-11-02 12:03:43 UTC
Thank you for fixing this and the printing issue (bug #618102)!

I observed bug #625147 which seems to be a duplicate of #618102. Btw. how do you generally deal with duplicates here on gnome.org bugzilla? Shall a reporter add a 'See Also' reference? Or just leave a comment? Is it up to the assignee?
Comment 6 Milan Crha 2010-11-02 17:14:15 UTC
(In reply to comment #5)
> I observed bug #625147 which seems to be a duplicate of #618102.

Thanks for noticing, I marked it as a duplicate. I think the duplicate entry is not available for all users, it's available only from certain level of priviledges in bugzilla.
Comment 7 Oliver Joos 2011-01-02 14:43:54 UTC
I confirm that this bug is fixed with 2.32.x in Fedora fc14 and Ubuntu 11.04 Natty alpha. Thanks!

Now end times are shown on screen only if enabled in preferences, and when printed they are always shown, which makes perfectly sense IMO.