After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632894 - Only show Desktop in file chooser button if there is one
Only show Desktop in file chooser button if there is one
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2010-10-22 14:06 UTC by Christian Dywan
Modified: 2010-11-03 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only show Desktop in file chooser button if there is one (859 bytes, patch)
2010-10-22 14:09 UTC, Christian Dywan 		none Details | Review

Description Christian Dywan 2010-10-22 14:06:25 UTC 
The file chooser button should only show a desktop if there is one, as opposed to the XDG_DESKTOP_DIR="$HOME" case.
Comment 1 Christian Dywan 2010-10-22 14:09:07 UTC 
Created attachment 173007 [details] [review]
Only show Desktop in file chooser button if there is one
Comment 2 Federico Mena Quintero 2010-10-22 16:19:22 UTC 
Good catch!  gtkfilechooserdefault.c uses g_strcmp0() to handle the NULL check automatically (in shortcuts_append_desktop()).  Please make that change and go ahead and push your patch.
Comment 3 Christian Dywan 2010-11-03 18:24:57 UTC 
Pushed, and also added the comment from shortcuts_append_desktop() which refers to the spec.