GNOME Bugzilla – Bug 632845
Allow adding songs to the play queue after currently playing track, album, or artist
Last modified: 2010-10-22 02:10:04 UTC
It would be neat to be able to queue tracks for after the current album, artist, or currently playing song. I tend to listen to my music in terms of albums, and also tend to queue entire discographies of bands and then get tired of a band long before listening to all of thier albums. This would enable finishing an album without manually rearranging the queue, something I have to do very often because of how I tend to listen to my music.
Created attachment 172966 [details] [review] [PlayQueue] Add 'Add after' feature for adding songs to queue Allows adding tracks to the play queue after the currently playing song, artist, or album.
Review of attachment 172966 [details] [review]: Looks good apart from two nitpicks below. Please commit after fixing them. ::: src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs @@ +335,3 @@ } + long max_view_order = MaxViewOrder - 1; + long view_order = CalculateViewOrder (mode); I'm not fond of the whole +/-1 juggling. MaxViewOrder should return the MAX(ViewOrder) and all its usages should be updated accordingly. @@ +356,3 @@ + case QueueMode.AfterCurrentAlbum: + case QueueMode.AfterCurrentTrack: + switch (mode) { I think `default: break;` can just be deleted. Also, you could turn it into `if (mode != QueueMode.Normal) Shift...;`
Created attachment 172970 [details] [review] [PlayQueue] Add 'Add after' feature for adding songs to queue Allows adding tracks to the play queue after the currently playing song, artist, or album.
Created attachment 172971 [details] [review] [PlayQueue] Add 'Add after' feature for adding songs to queue Allows adding tracks to the play queue after the currently playing song, artist, or album.
Attachment 172971 [details] pushed as e51ceb1 - [PlayQueue] Add 'Add after' feature for adding songs to queue