After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632844 - gjs-console: explicitely link against glib
gjs-console: explicitely link against glib
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-22 00:28 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2010-10-25 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gjs-console: explicitely link against glib (706 bytes, patch)
2010-10-22 00:28 UTC, Diego Escalante Urrelo (not reading bugmail) 		rejected Details | Review
console: Only use basic GJS API <gjs/gjs.h> and link against GLib (3.30 KB, patch)
2010-10-22 15:09 UTC, Colin Walters 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2010-10-22 00:28:56 UTC 
Comeback of bug #626672. Had been fixed in 7cbbd0016a3ed5d15f3e794d72d962a4be05c858.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2010-10-22 00:28:58 UTC 
Created attachment 172964 [details] [review]
gjs-console: explicitely link against glib

Otherwise the build fails.

Bug #632844
Comment 2 Colin Walters 2010-10-22 15:00:45 UTC 
Review of attachment 172964 [details] [review]:

::: Makefile.am
@@ +123,3 @@
 gjs_console_LDADD =		\
+	$(GJS_LIBS)		\
+	libgjs.la

Actually this isn't quite right; I intentionally didn't want to link gjs-console against e.g. mozjs.so.  We need to check for glib separately.
Comment 3 Colin Walters 2010-10-22 15:09:34 UTC 
Created attachment 173014 [details] [review]
console: Only use basic GJS API <gjs/gjs.h> and link against GLib

We need to link explicitly against GObject, since we use The
commit 25681375970de9 intentionally removed the dependency on all
the "internal" GJS libraries like libmozjs.so from gjs-console,
but first, we need to explicitly link against libgobject, because
we do use it.

Secondly, to make things more clear here, drop the random unnecessary
use of "internal" GJS API like gjs_debug and gjs_memory_report (
the memory report could be an environment variable).
Comment 4 Colin Walters 2010-10-22 15:09:49 UTC 
Can you try this patch?
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2010-10-25 06:54:58 UTC 
(In reply to comment #4)
> Can you try this patch?

Works for me!
Comment 6 Colin Walters 2010-10-25 20:22:53 UTC 
Attachment 173014 [details] pushed as c9f30e1 - console: Only use basic GJS API <gjs/gjs.h> and link against GLib