After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632803 - gnome-applets doesn't build with libnotify 0.7
gnome-applets doesn't build with libnotify 0.7
Product: gnome-applets
Classification: Other
Component: general
Other Linux
: Urgent critical
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Reported: 2010-10-21 16:01 UTC by Lucas Rocha
Modified: 2010-12-10 08:54 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

patch (635 bytes, patch)
2010-11-03 21:07 UTC, Matthias Clasen
none Details | Review

Description Lucas Rocha 2010-10-21 16:01:46 UTC
weather-applet.c: In function ‘update_finish’:
gweather-applet.c:475: error: too many arguments to function ‘notify_notification_new’
make[3]: ** [gweather-applet.o] Erro 1
Comment 1 Matthias Clasen 2010-11-03 21:07:07 UTC
Created attachment 173801 [details] [review]
Comment 2 André Klapper 2010-11-21 02:31:58 UTC
mclasen: Feel free to commit to master (no idea who could review this, but the patch is so trivial) and to bump LIBNOTIFY_REQUIRED=0.3.2 in
Comment 3 Florian Gawrilowicz 2010-11-29 12:16:59 UTC
works for me...
Comment 4 Enrico Minack 2010-12-10 06:26:42 UTC
The patch also works for me. I will commit this to master, soon.

Why exactly bump LIBNOTIFY_REQUIRED to 0.3.2 where the bug subject says libnotify 0.7? Is 0.3.2 the version where notify_notification_new with three arguments first appeared and 0.7 where the method with four arguments were removed from the API?

Btw., the old method is also used for the battery status applet and can be fixed in the same way.
Comment 5 Enrico Minack 2010-12-10 08:07:51 UTC
Ah, I understand, I checked the git log and this three argument method was added with the 0.7 release, there was no deprecation phase...