GNOME Bugzilla – Bug 632803
gnome-applets doesn't build with libnotify 0.7
Last modified: 2010-12-10 08:54:33 UTC
weather-applet.c: In function ‘update_finish’:
gweather-applet.c:475: error: too many arguments to function ‘notify_notification_new’
make: ** [gweather-applet.o] Erro 1
Created attachment 173801 [details] [review]
mclasen: Feel free to commit to master (no idea who could review this, but the patch is so trivial) and to bump LIBNOTIFY_REQUIRED=0.3.2 in configure.in.
works for me...
The patch also works for me. I will commit this to master, soon.
Why exactly bump LIBNOTIFY_REQUIRED to 0.3.2 where the bug subject says libnotify 0.7? Is 0.3.2 the version where notify_notification_new with three arguments first appeared and 0.7 where the method with four arguments were removed from the API?
Btw., the old method is also used for the battery status applet and can be fixed in the same way.
Ah, I understand, I checked the git log and this three argument method was added with the 0.7 release, there was no deprecation phase...
Fixed in commit http://git.gnome.org/browse/gnome-applets/commit/?id=f6b5bf454a61ca0090a1a32b798045a807d8ddad