GNOME Bugzilla – Bug 632789
[PATCH] tests/icles/: adapted test-colorkey.c and test-xoverlay.c to deprecation of gtk_widget_hide_all
Last modified: 2010-10-21 13:51:00 UTC
Created attachment 172931 [details] [review] Replaces gtk_widget_hide_all with gtk_widget_hide GTK-2.24 deprecated this function in favor of gtk_widget_hide.
Thanks for taking the time to report this bug. This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade. *** This bug has been marked as a duplicate of bug 625001 ***
Oh sorry, I was too fast. Yes, this patch is valid and should be included but use the replacement function only conditionally in an #if GTK_CHECK_VERSION(x,y,z) #endif block if the old gtk_widget_hide() had a different behaviour.
I've just changed them all to gtk_widget_hide(). Should be fine. I don't think it matters here anyway, since this is just before shut down. We may just as well remove it. commit 8cd8339893743f674aa658459e66af4bccdc8838 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Thu Oct 21 13:38:01 2010 +0100 tests: don't use deprecated gtk_widget_hide_all() gtk_widget_hide_all() has been deprecated in gtk+ 2.x and removed in 2.9x master. Just use gtk_widget_hide() instead. Flo: sorry, hadn't seen your patch when I pushed this, bug mail seems to be a bit slow today.