After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632733 - volumeIndicator: Add mousewheel support
volumeIndicator: Add mousewheel support
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Giovanni Campagna
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-20 19:26 UTC by drago01
Modified: 2010-10-20 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
volumeIndicator: Add mousewheel support (2.03 KB, patch)
2010-10-20 19:27 UTC, drago01 		none Details | Review
volumeIndicator: Add mousewheel support (2.03 KB, patch)
2010-10-20 19:51 UTC, drago01 		none Details | Review
volumeIndicator: Add mousewheel support (2.01 KB, patch)
2010-10-20 19:54 UTC, drago01 		committed Details | Review

Description drago01 2010-10-20 19:26:29 UTC 
I (and I suppose many others) have the habit to adjust the volume using the mousewheel so restore that feature as there is no real reason to remove it.
Comment 1 drago01 2010-10-20 19:27:47 UTC 
Created attachment 172871 [details] [review]
volumeIndicator: Add mousewheel support

Allow changing the volume by moving the mousewheel over the volume indicator
to restore the old gnome-volume-control-applet behaviour.
Comment 2 Giovanni Campagna 2010-10-20 19:45:48 UTC 
Review of attachment 172871 [details] [review]:

::: js/ui/status/volume.js
@@ +83,3 @@
+            this['_output'].push_volume();
+        }
+    },

Why this['_output'] and not this._output?
The latter is faster in a JIT implementation
Comment 3 drago01 2010-10-20 19:51:48 UTC 
Created attachment 172875 [details] [review]
volumeIndicator: Add mousewheel support

Allow changing the volume by moving the mousewheel over the volume indicato
to restore the old gnome-volume-control-applet behaviour.

---

Fix typo pointed out by Florian.
Comment 4 drago01 2010-10-20 19:53:26 UTC 
(In reply to comment #2)
> Review of attachment 172871 [details] [review]:
> 
> ::: js/ui/status/volume.js
> @@ +83,3 @@
> +            this['_output'].push_volume();
> +        }
> +    },
> 
> Why this['_output'] and not this._output?
> The latter is faster in a JIT implementation

No specific reason ...
Comment 5 drago01 2010-10-20 19:54:21 UTC 
Created attachment 172876 [details] [review]
volumeIndicator: Add mousewheel support

Use this._output rather than this.['_output']
Comment 6 Giovanni Campagna 2010-10-20 19:58:03 UTC 
Review of attachment 172876 [details] [review]:

Looks good to me, but you should wait for an official maintainer to get the green light
Comment 7 drago01 2010-10-20 20:06:22 UTC 
Attachment 172876 [details] pushed as 10e59c0 - volumeIndicator: Add mousewheel support