GNOME Bugzilla – Bug 632654
[matroskamux] try to write timestamps in most of the outgoing buffers
Last modified: 2010-12-06 14:23:25 UTC
Created attachment 172810 [details] [review] matroskamux: write timestamps in all the outgoing buffers Many buffers, like ebml's buffer headers, doesn't have any timestamp info. This patch adds it when it's possible.
Before the patch: 15 bytes, timestamp: none, duration: none, offset: -1, offset_end: -1, flags: 0) 0x82332f0" 7 bytes, timestamp: none, duration: none, offset: -1, offset_end: -1, flags: 256) 0x8233340" 2975 bytes, timestamp: 0:00:00.000000000, duration: 0:00:00.033333333, offset: 33333333, offset_end: 7516192768, flags: 256) 0x8206d60" 7 bytes, timestamp: none, duration: none, offset: -1, offset_end: -1, flags: 256) 0x8233160" 2304 bytes, timestamp: 0:00:00.033333333, duration: 0:00:00.033333333, offset: 66666666, offset_end: 11811160072, flags: 256) 0x82332a0" After the patch: 15 bytes, timestamp: 0:00:00.000000000, duration: none, offset: -1, offset_end: -1, flags: 0) 0x870aad0" 7 bytes, timestamp: 0:00:00.000000000, duration: none, offset: -1, offset_end: -1, flags: 256) 0x870ab20" 2975 bytes, timestamp: 0:00:00.000000000, duration: 0:00:00.033333333, offset: 33333333, offset_end: 7516192768, flags: 256) 0x86e1960" 7 bytes, timestamp: 0:00:00.033333333, duration: none, offset: -1, offset_end: -1, flags: 256) 0x870a940" 2304 bytes, timestamp: 0:00:00.033333333, duration: 0:00:00.033333333, offset: 66666666, offset_end: 11811160072, flags: 256) 0x870aa80" 19 bytes, timestamp: 0:00:00.066666666, duration: none, offset: -1, offset_end: -1, flags: 256) 0x86e1a00" 2272 bytes, timestamp: 0:00:00.066666666, duration: 0:00:00.033333334, offset: 100000000, offset_end: 16106127376, flags: 256) 0x870a850"
Created attachment 172813 [details] [review] 0001-matroskamux-try-to-write-timestamps-in-all-the-outgo.patch Rebase commit with current HEAD
Assuming that the intention is for header buffers to have timestamp 0 (as in above debug output), latest patch was modified a bit (i.e. turn _TIME_NONE used in _mux_start and ebml_write_header into 0). commit fd6bc949c8c3a9fc5ee48b0f0c3eef96f721a3ec Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Wed Oct 20 11:05:49 2010 +0200 matroskamux: try to write timestamps in all the outgoing buffers Fixes #632654.