GNOME Bugzilla – Bug 632653
[seek] Don't use deprecated combo box API
Last modified: 2010-10-30 15:11:14 UTC
Created attachment 172809 [details] [review] patch it is being replaced by GtkComboBoxText in GTK3
As this API was added in 2.24 we can only use it conditionally for now in an #if GTK_CHECK_VERSION() block. Will push the patch with this change after the release.
But of course it's not available in 2.91.0...
Created attachment 172811 [details] [review] seek: The new combo box text API is available since 2.23.0 and 2.91.1 Only use it conditionally.
commit 10c693c696483b77f188abb06fe635b71c7fd120 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Wed Oct 20 11:01:59 2010 +0200 seek: The new combo box text API is available since 2.23.0 and 2.91.1 Only use it conditionally. commit 95db0704703cfdb2fdb5ad2d1edf7f87a93a5812 Author: Matthias Clasen <mclasen@redhat.com> Date: Wed Oct 20 11:01:14 2010 +0200 seek: Don't use deprecated combo box text API Fixes bug #632653.
The committed patch was incomplete, it seems. Here is a followup patch that makes things compile. I didn't ifdef it up, since that would be a little excessive. It might be more practical to define the new api for old gtk, like #define gtk_combo_box_text_new gtk_combo_box_new_text #define gtk_combo_box_text_append_text gtk_combo_box_append_text #define GTK_COMBO_BOX_TEXT GTK_COMBO_BOX
Created attachment 173371 [details] [review] new patch
Created attachment 173396 [details] [review] seek: Define the new combobox API to the old functions if using older GTK
Looks good to me; of course, you should drop it once you can rely on a new enough gtk
Thanks for the patches! > Looks good to me; of course, you should drop it once you can rely on a new > enough gtk That probably won't be before Gtk+ 3.0 has hit the distros, so not before April/May 2011 most likely :) commit bb7e76e88920269a1a0f8d73882e8161b38b5984 Author: Matthias Clasen <mclasen@redhat.com> Date: Sat Oct 30 16:03:18 2010 +0100 examples: update some more code for new Gtk+ API, with fallback for older Gtk+ versions Move code to new Gtk+ 3.x / 2.9x API. We have defines in place already that make this code work fine on older Gtk+ 2.x. https://bugzilla.gnome.org/show_bug.cgi?id=632653 commit 9f9e5f80aa15c62b211a31142f7a2f22aa03c0e9 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Thu Oct 28 15:13:45 2010 +0200 seek: Define the new combobox API to the old functions if using older GTK https://bugzilla.gnome.org/show_bug.cgi?id=632653