GNOME Bugzilla – Bug 632566
Port to new gnome-bg API (GSettings)
Last modified: 2010-11-19 15:52:57 UTC
Created attachment 172732 [details] [review] proposed patch In relation with the work going on in bug 626021 also gnome-screensaver needs a few changes for the modified gnome-bg API. First we need to get gnome-desktop (#626021) part in, then adapt its users. BTW.: I noticed that changes made to background settings (by some other process) are not picked, I guess there's a reason for that.
Comment on attachment 172732 [details] [review] proposed patch Doesn't seem right to me. The idea of loading the preferences from a client that uses the default sources is so that the settings for the user aren't used but rather the system default settings are used. This patch seems to just use the user's settings.
Created attachment 173826 [details] [review] proposed patch (In reply to comment #1) > (From update of attachment 172732 [details] [review]) > Doesn't seem right to me. The idea of loading the preferences from a client > that uses the default sources is so that the settings for the user aren't used > but rather the system default settings are used. > > This patch seems to just use the user's settings. Okay, I was not aware of that. Attached is a new patch, loading default values. But it's still a hack, since we probably don't have any way to access 'system' settings at the moment. This is something that needs to be implemented in GSettings first. I've also disabled change notification, we'd only receive user changes anyway.
Comment on attachment 173826 [details] [review] proposed patch let's go ahead and get this committed. we can add a new separate key for gdm/gnome-screensaver background later i guess.
commit 22aff5e2a8c8faa8608cd38951665ccb175d6953 Author: Tomas Bzatek <tbzatek@redhat.com> Date: Fri Nov 19 14:26:14 2010 +0100 Port background handling to GSettings and new gnome-bg API See bug 632566 for details.