After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632548 - [rtspsrc] regression; fails to report duration
[rtspsrc] regression; fails to report duration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-19 12:32 UTC by Mark Nauwelaerts
Modified: 2010-10-20 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtspsrc: init segment prior to storing duration info in it (1.00 KB, patch)
2010-10-19 12:32 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-10-19 12:32:39 UTC 
Created attachment 172707 [details] [review]
rtspsrc: init segment prior to storing duration info in it

After some reshuffling in rtspsrc a while ago, current code order in open_from_sdp is now (a.o.):

...
  /* parse range for duration reporting. */
  /* -> stored in src->segment */
...
  gst_segment_init (&src->segment, GST_FORMAT_TIME);
  /* ==> losing result obtaining above */

Since servers (apparently) might reply with a "npt=0-" range, duration info is lost.

Provided patch restores earlier behaviour (i.e. retaining duration info obtained from SDP).
Comment 1 Sebastian Dröge (slomo) 2010-10-19 14:28:16 UTC 
Looks good, can we get this into the next release?
Comment 2 Tim-Philipp Müller 2010-10-19 14:42:23 UTC 
Comment on attachment 172707 [details] [review]
rtspsrc: init segment prior to storing duration info in it

Looks good, please push. Would be great if you could rephrase the commit message a bit to make it clearer what effect this change has (e.g. rtspsrc: fix duration reporting \ Init segment prior to....)
Comment 3 Mark Nauwelaerts 2010-10-19 15:23:23 UTC 
commit ca7870de496c31f5377b1cdecd32de59921d61a9
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Oct 19 16:45:51 2010 +0200

    rtspsrc: fix duration reporting
    
    Init segment prior to storing duration info in it.
    
    Fixes #632548.