After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632539 - Do not install gtkprivate.h
Do not install gtkprivate.h
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.91.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-10-19 11:08 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-10-20 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Do not install gtkprivate.h (1.00 KB, patch)
2010-10-19 11:08 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
Split off gtkprivate.h (15.67 KB, patch)
2010-10-19 18:08 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2010-10-19 11:08:33 UTC 
The gtkprivate.h header is - as the name implies - private. And yet we install it anyway.

Worse, we actually scan it for introspection, which leads to interesting warnings.

The attached patch moves gtkprivate.h into the private header files where it belongs.
Comment 1 Emmanuele Bassi (:ebassi) 2010-10-19 11:08:36 UTC 
Created attachment 172691 [details] [review]
build: Do not install gtkprivate.h

This is a private header file, and it should *not* be installed. It
should also not be scanned by the introspection machinery.
Comment 2 Emmanuele Bassi (:ebassi) 2010-10-19 18:08:41 UTC 
Created attachment 172749 [details] [review]
Split off gtkprivate.h

The gtkprivate.h header contains GtkWidget-specific private symbols that
are not useful except in a handful of cases. Basically everything
includes gtkprivate.h for the GTK_PARAM_* macros.
Comment 3 Emmanuele Bassi (:ebassi) 2010-10-20 09:36:04 UTC 
Attachment 172691 [details] pushed as 9b34bf1 - build: Do not install gtkprivate.h
Attachment 172749 [details] pushed as 2cc059a - Split off gtkprivate.h