After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632227 - [PATCH] alacarte still has icons in buttons
[PATCH] alacarte still has icons in buttons
Status: RESOLVED FIXED
Product: alacarte
Classification: Applications
Component: general
0.13.x
Other Linux
: Normal trivial
: ---
Assigned To: Alacarte Maintainer(s)
Alacarte Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-10-15 15:19 UTC by rugby471
Modified: 2011-08-22 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of Issue (97.85 KB, image/png)
2010-10-15 15:19 UTC, rugby471 		  Details
Patch to fix the issue (35.02 KB, patch)
2010-10-15 15:20 UTC, rugby471 		none Details | Review
Patch that actually fixes the issue (25.25 KB, patch)
2010-10-25 07:02 UTC, rugby471 		committed Details | Review
Avoid icons in buttons (25.64 KB, patch)
2011-08-22 18:41 UTC, Olav Vitters 		committed Details | Review

Description rugby471 2010-10-15 15:19:57 UTC 
Created attachment 172434 [details]
Screenshot of Issue

Reported at https://bugs.launchpad.net/ubuntu/+source/alacarte/+bug/658979

Alacarte still has icons in buttons even when this is disabled in gconf's /desktop/gnome/interface/buttons_have icons.

As you can see in the screenshot attached, the problem is in the 'New Menu', 'New Item', 'Move Up' and 'Move Down' buttons. This is because in the Glade UI file at /usr/share/alacarte/alacarte.ui, the buttons use a custom container to hold the text and button in, rather than the 'Label and Optional Image' option.

Attached is a simple patch to fix this issue
Comment 1 rugby471 2010-10-15 15:20:46 UTC 
Created attachment 172435 [details] [review]
Patch to fix the issue
Comment 2 André Klapper 2010-10-24 18:05:19 UTC 
Your patch does not delete a single line but only adds content.
Is that intended?
Comment 3 rugby471 2010-10-25 07:02:11 UTC 
Created attachment 173152 [details] [review]
Patch that actually fixes the issue

My apologies, I must have created the patch incorrectly.

Here is the patch that actually works :)
Comment 4 Olav Vitters 2011-08-22 18:41:16 UTC 
The following fix has been pushed:
3d4bbfd Avoid icons in buttons
Comment 5 Olav Vitters 2011-08-22 18:41:25 UTC 
Created attachment 194409 [details] [review]
Avoid icons in buttons