GNOME Bugzilla – Bug 632225
Split 'show-desktop' key from Nautilus
Last modified: 2010-10-19 13:50:51 UTC
Created attachment 172432 [details] [review] gsettings-desktop-schemas patch In relation to bug 628624 we need to split settings for desktop handling to a more general schema. This key would indicate that file managers (by default Nautilus but applies to others like Thunar or ROX) should handle desktop, i.e. draw a background and place icons there. Otherwise gnome-settings-daemon will take care of background stuff when set to FALSE. The difference to 'draw-background' is that this is a separate option used only for drawing background without icons. 'show-desktop-icons' kinda implies 'draw-background', we handle that in Nautilus and not showing desktop at all (TBC). Feel free to propose better key name or placement. Nautilus patch will follow soon.
Created attachment 172613 [details] [review] nautilus patch Nautilus patch, removing local 'show-desktop' settings and using the global 'show-desktop-icons' one.
Review of attachment 172432 [details] [review]: Looks good to me, though there's no need to mention nautilus or "Gnome". ::: schemas/org.gnome.desktop.background.gschema.xml.in @@ +54,3 @@ + <key name="show-desktop-icons" type="b"> + <default>true</default> + <summary>Have Gnome file manager handle the desktop</summary> Remove the "Gnome" in there (it should have been GNOME as well).
Review of attachment 172613 [details] [review]: The nautilus patch looks good here.
Committed, thanks for your comments. gsettings-desktop-schemas: commit 87f74e3820042b6c06b8265497405e3c8e210497 Author: Tomas Bzatek <tbzatek@redhat.com> Date: Tue Oct 19 15:30:50 2010 +0200 Split 'show-desktop' from Nautilus nautilus: commit 1f135b5da410b7a0052d22322d740037036b39b0 Author: Tomas Bzatek <tbzatek@redhat.com> Date: Tue Oct 19 15:47:50 2010 +0200 Use gnome global 'show-desktop-icons' settings See bug 632225 for details.