After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632151 - main: use Meta.Display.get_keybinding_action for PrintScreen as well
main: use Meta.Display.get_keybinding_action for PrintScreen as well
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Owen Taylor
gnome-shell-maint
: 619777 629952 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-14 14:39 UTC by Dan Winship
Modified: 2011-01-06 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: use Meta.Display.get_keybinding_action for PrintScreen as well (4.25 KB, patch)
2010-10-14 14:39 UTC, Dan Winship 		committed Details | Review
"diff -w" version of the patch, since it's mostly just reindentation (2.22 KB, patch)
2010-10-14 14:40 UTC, Dan Winship 		reviewed Details | Review

Description Dan Winship 2010-10-14 14:39:38 UTC 
requires mutter bug 632149
Comment 1 Dan Winship 2010-10-14 14:39:40 UTC 
Created attachment 172358 [details] [review]
main: use Meta.Display.get_keybinding_action for PrintScreen as well

(and trigger it on keyrelease rather than keypress, like the other
bindings)
Comment 2 Dan Winship 2010-10-14 14:40:35 UTC 
Created attachment 172359 [details] [review]
"diff -w" version of the patch, since it's mostly just reindentation
Comment 3 drago01 2010-10-14 16:25:03 UTC 
*** Bug 629952 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2010-10-20 17:13:19 UTC 
Review of attachment 172358 [details] [review]:

Looks fine
Comment 5 Owen Taylor 2010-10-20 17:16:53 UTC 
Review of attachment 172358 [details] [review]:

Though I have no idea why we are triggering key bindings on release rather than press - I think this is some accidental fallout from making the super binding handled on release rather than press as a special case - for consistency with the main view where we didn't want to break its use as a modifier for other key bindings.
Comment 6 Owen Taylor 2010-10-20 17:17:37 UTC 
Review of attachment 172359 [details] [review]:

Marking 'diff -w' patch as reviewed to get the bug out of bugzilla queries.
Comment 7 Owen Taylor 2010-10-20 17:17:38 UTC 
Review of attachment 172359 [details] [review]:

Marking 'diff -w' patch as reviewed to get the bug out of bugzilla queries.
Comment 8 Dan Winship 2010-10-25 20:40:58 UTC 
Attachment 172358 [details] pushed as c217377 - main: use Meta.Display.get_keybinding_action for PrintScreen as well
Comment 9 drago01 2011-01-06 18:53:32 UTC 
*** Bug 619777 has been marked as a duplicate of this bug. ***