After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632147 - iconGrid: Add alignment parameter
iconGrid: Add alignment parameter
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-14 13:45 UTC by Florian Müllner
Modified: 2010-10-14 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
iconGrid: Add alignment parameter (1.89 KB, patch)
2010-10-14 13:45 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-10-14 13:45:03 UTC 
See attached patch. The patch is already in the overview-relayout branch, but it's sufficiently independent to land in master before the branch, so I'm putting it up for review ...
Comment 1 Florian Müllner 2010-10-14 13:45:06 UTC 
Created attachment 172350 [details] [review]
iconGrid: Add alignment parameter

Currently the grid's content is centered, which is not appropriate
for all use cases. Add an optional parameter to control the alignment.
Comment 2 Dan Winship 2010-10-14 14:53:16 UTC 
Comment on attachment 172350 [details] [review]
iconGrid: Add alignment parameter

maybe rename "overallPaddingX"? not a big deal (and no need to resubmit the patch if you do)
Comment 3 Florian Müllner 2010-10-14 15:47:22 UTC 
Attachment 172350 [details] pushed as 627f1cb - iconGrid: Add alignment parameter

Pushed with s/overallPaddingX/leftPadding/