After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632119 - Add WSUM 91.7FM (University of Wisconsin) to iRadio-Initial.pls
Add WSUM 91.7FM (University of Wisconsin) to iRadio-Initial.pls
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Internet Radio
0.13.x
Other All
: Normal trivial
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-14 04:37 UTC by kyleabaker
Modified: 2010-10-19 02:00 UTC
See Also:
GNOME target: 2.32.x
GNOME version: 2.31/2.32


Attachments
iradio-initial-patch.log (412 bytes, patch)
2010-10-14 04:37 UTC, kyleabaker
needs-work Details | Review

Description kyleabaker 2010-10-14 04:37:53 UTC
Created attachment 172327 [details] [review]
iradio-initial-patch.log

This is a patch to add the ogg format radio station for WSUM 91.7FM (University of Wisconsin) Student Radio as requested by Matt Rockwell via the Rhythmbox mailing list.

That diff/patch file was compiled against the Rhythmbox 0.13.1 iradio-initial.pls.
Comment 1 Jonathan Matthew 2010-10-17 01:41:40 UTC
Comment on attachment 172327 [details] [review]
iradio-initial-patch.log

The initial radio stream list is now an XSPF file, so this patch doesn't apply.
Comment 2 Jonathan Matthew 2010-10-17 01:54:08 UTC
Also, please don't set target GNOME versions on rhythmbox bugs.  Even for important bugs (which this isn't), saying a bug "must be fixed before/in GNOME 2.32.x" is meaningless here.
Comment 3 kyleabaker 2010-10-17 02:52:00 UTC
I fetched Rhythmbox 0.13.1 from here:
http://ftp.gnome.org/pub/GNOME/sources/rhythmbox/0.13/

.., and originally attempted to file a patch in the XSPF format (as I've done before), but I was unable to locate the initial radio xspf file to diff against in the archive. The only file still present in that archive relating to this seems to be the iradio-initial.pls.

I'm not sure if I've just missed it in there or if its missing, but its not obvious by looking at 0.13.1 that pls isn't still in use. ;) If you could kindly point me toward this XSPF file then that would be of great help.

Otherwise, this is the additional station thats been requested:

    <track>
      <title>WSUM 91.7FM (University of Wisconsin)</title>
      <location>http://vu.wsum.wisc.edu/wsumlive.m3u</location>
      <genre>Student</genre>
    </track>

If you can direct me to the XSPF file then I'll also attach the appropriate patch.
Comment 4 Jonathan Matthew 2010-10-17 02:55:03 UTC
We switch to xspf after 0.13.1.

http://git.gnome.org/browse/rhythmbox/tree/plugins/iradio/iradio-initial.xspf
Comment 5 Jonathan Matthew 2010-10-19 02:00:13 UTC
added in commit 521ab35