After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632024 - Be able to start contact search using menu
Be able to start contact search using menu
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.32.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-13 02:38 UTC by Jean-François Fortin Tam
Modified: 2010-11-08 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (2.35 KB, patch)
2010-10-15 22:53 UTC, Vitaly Minko
reviewed Details | Review

Description Jean-François Fortin Tam 2010-10-13 02:38:44 UTC
We all like minimalist design and the coolness of having a search bar magically appear as you type into the contact list, however, this goes against common usability principles. 
Namely, the current search bar is not discoverable by anyone but geeks (or people who have cats walking onto their keyboards while the contact list is in focus).

So, my suggestion is to show the search bar by default (I presume we can afford those 10 pixels), or, if you don't want that, you could have an action to bring it up in the menus at the very least.
However, if you "only" put it in the menus, users might (or probably, "will") not be aware of its existence. From experience, mom and pop don't go looking into menus.
Comment 1 Guillaume Desmottes 2010-10-13 07:18:50 UTC
Vertical space is a precious ressource, so I don't think always displaying the bar is a good idea. But indeed, we could add a "Search" entry in the "Edit" menu (like in Epiphany).
Comment 2 Vitaly Minko 2010-10-15 22:49:03 UTC
Fixed in
repo: git://vminko.org/empathy
branch: fix-632024
Comment 3 Vitaly Minko 2010-10-15 22:53:25 UTC
Created attachment 172465 [details] [review]
proposed fix

In case I did something wrong with git...
Comment 4 Guillaume Desmottes 2010-10-18 08:11:32 UTC
Review of attachment 172465 [details] [review]:

Your commit message isn't very informative. I'd prefer something like "Add an entry in the Edit menu to search for contacts (#632024).

::: empathy-2.32.0.1/src/empathy-main-window.c
@@ +958,3 @@
+
+	g_signal_emit_by_name (priv->individual_view,
+			       "start-interactive-search");

Firing a signal on another object is not very clear. I'd prefer if you add API on the individual view.

@@ +960,3 @@
+			       "start-interactive-search");
+}
+ 

There is a trailing space here; please remove it. git diff and git show you show you trailing spaces in red.

::: empathy-2.32.0.1/src/empathy-main-window.ui
@@ +169,3 @@
+          <object class="GtkAction" id="view_search_contacts">
+            <property name="name">view_search_contacts</property>
+            <property name="label" translatable="yes">Find in Contact _List</property>

That's a bit long. "Find Contact" ?
Comment 5 Vitaly Minko 2010-10-18 11:55:57 UTC
>I'd prefer something like "Add an entry in the Edit menu to search for contacts (#632024).

I added the new item in the View menu, because I think it's more suitable for this item. Isn't it?

>Firing a signal on another object is not very clear. I'd prefer if you add API
on the individual view.
>There is a trailing space here;

Fixed in fix-632024-v2

>That's a bit long. "Find Contact" ?

I believe that this long name is justified in this case, because we should explicitly distinguish this feature from the 'search contacts in the net' (which does not seem to be supported by empathy, but is quite common). Moreover, it's no longer than 'Previous Conversations", for example. If you don't agree - I will change it.
Comment 6 Guillaume Desmottes 2010-10-18 12:20:10 UTC
(In reply to comment #5)
> >I'd prefer something like "Add an entry in the Edit menu to search for contacts (#632024).
> 
> I added the new item in the View menu, because I think it's more suitable for
> this item. Isn't it?

Humm; I'd still be tempted to say it belongs to Edit: that's more coherent with other app such as Epiphany and "View" is usually used to display persistent options, while here it's more an action.
 
> >That's a bit long. "Find Contact" ?
> 
> I believe that this long name is justified in this case, because we should
> explicitly distinguish this feature from the 'search contacts in the net'
> (which does not seem to be supported by empathy, but is quite common).
> Moreover, it's no longer than 'Previous Conversations", for example. If you
> don't agree - I will change it.

Fair enough.
Comment 7 Vitaly Minko 2010-10-18 12:53:38 UTC
>I'd still be tempted to say it belongs to Edit

Fixed in the same branch (fix-632024-v2).
Comment 8 Guillaume Desmottes 2010-10-18 13:26:18 UTC
Sorry for nit picking, but "Preferences" is usually the latest item of the Edit menu in all GNOME apps. I'd put it after personnal info (and before the separator).
Comment 9 Vitaly Minko 2010-10-18 13:53:27 UTC
Sorry I should have noticed that. Fixed in the same branch (fix-632024-v2).
Comment 10 Guillaume Desmottes 2010-10-18 14:38:30 UTC
I accidentally merged an older version of your branch and moved it myself. Thanks a lot!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.