After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631980 - Handle an optional <revision> node in the report's XML
Handle an optional <revision> node in the report's XML
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-10-12 15:09 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-12-28 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtester-report: Add an optional 'revision' node (1.57 KB, patch)
2010-10-12 15:09 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
test: Add a <revision> node to the report XML (2.05 KB, patch)
2010-10-12 15:09 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2010-10-12 15:09:07 UTC 
Just like gtester-reports handles the package name and version it should also handle a particular revision; this is useful for comparing reports coming from different revisions, both in the manual and the automated cases.
Comment 1 Emmanuele Bassi (:ebassi) 2010-10-12 15:09:10 UTC 
Created attachment 172192 [details] [review]
gtester-report: Add an optional 'revision' node

In order to distinguish reports generated from a specific revision of a
projects it would be good if gtester-report handled a <revision> node in
the XML.

The payload is free-form, just like for the other nodes under <info>.
Comment 2 Emmanuele Bassi (:ebassi) 2010-10-12 15:09:14 UTC 
Created attachment 172193 [details] [review]
test: Add a <revision> node to the report XML

Use `git describe` to fill out the <revision> node, if we're using a
git checkout; otherwise, for tests ran from a released tarball, use
the version.
Comment 3 Matthias Clasen 2010-12-28 05:24:50 UTC 
Review of attachment 172192 [details] [review]:

Looks fine to me.
Comment 4 Matthias Clasen 2010-12-28 05:25:27 UTC 
Review of attachment 172193 [details] [review]:

Looks fine to me.
Comment 5 Emmanuele Bassi (:ebassi) 2010-12-28 17:07:53 UTC 
Attachment 172192 [details] pushed as 52c8310 - gtester-report: Add an optional 'revision' node
Attachment 172193 [details] pushed as 500061f - test: Add a <revision> node to the report XML