After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631825 - Calibration won't start, argyll gets stuck
Calibration won't start, argyll gets stuck
Status: RESOLVED FIXED
Product: gnome-color-manager
Classification: Core
Component: general
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-color-manager-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-10 17:06 UTC by Pascal de Bruijn
Modified: 2011-10-03 07:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
argyll waiting for key press (20.74 KB, text/plain)
2010-10-10 17:06 UTC, Pascal de Bruijn
  Details
test patch (528 bytes, patch)
2010-10-12 07:48 UTC, Richard Hughes
none Details | Review
test patch (2.16 KB, patch)
2010-10-13 08:47 UTC, Richard Hughes
needs-work Details | Review

Description Pascal de Bruijn 2010-10-10 17:06:39 UTC
Created attachment 172054 [details]
argyll waiting for key press

Hi,

Using GCM 2.32.0 on Ubuntu Maverick (10.10), it seems calibration does not start, because Argyll is waiting for someone to press enter...

When I open the VTE and press enter, the calibration _does_ continue... 

I do not have this issue on Ubuntu Lucid (10.04) using GCM 2.32.0, so I'm guessing this is some libvte misery?
Comment 1 Pascal de Bruijn 2010-10-10 17:07:33 UTC
These are my libvte versions:

ii  libvte-common                         1:0.26.0-0ubuntu1                               
ii  libvte-dev                            1:0.26.0-0ubuntu1                               
ii  libvte9                               1:0.26.0-0ubuntu1
Comment 2 Richard Hughes 2010-10-11 09:27:12 UTC
If you open the VTE, and press " " (single space) does argyll also continue? We're correctly noticing that argyll needs input, and is sending a space. It appears argyll is refusing to play ball :-)
Comment 3 Pascal de Bruijn 2010-10-11 15:34:49 UTC
Nope...

Pressing ENTER does do the trick however...
Comment 4 Richard Hughes 2010-10-12 07:48:05 UTC
Created attachment 172164 [details] [review]
test patch

Could you try this patch please. Thanks.
Comment 5 Pascal de Bruijn 2010-10-12 20:54:45 UTC
Works... well at least in the first instance, since this problem exist for both dispcal and dispread...
Comment 6 Richard Hughes 2010-10-13 08:47:51 UTC
Created attachment 172240 [details] [review]
test patch

Can you try this patch please, and check that the whole calibration succeeds. I'm really annoyed that you can't now press space for "any" key in newer versions of argyll. Thanks dude.
Comment 7 Pascal de Bruijn 2010-10-14 19:13:32 UTC
Seems to work... Tested with both the Huey and the ColorMunki.

I did manually try dispcal, which _does_ continue when space is pressed, so I guess this isn't argyll's fault.
Comment 8 Michael Hamann 2011-10-02 23:34:42 UTC
I can confirm both the problem (I have the Huey, too) and that the patch works (for me), the whole calibration succeeds and the result seems to be okay (similar to the result I got when I've manually used argyll). Is there any reason why this patch hasn't been applied yet? I can imagine that you don't consider it the prettiest fix, but it works and shouldn't cause any problems for other versions of argyll.
Comment 9 Richard Hughes 2011-10-03 07:54:53 UTC
(In reply to comment #8)
> I can confirm both the problem (I have the Huey, too) and that the patch works
> (for me), the whole calibration succeeds and the result seems to be okay
> (similar to the result I got when I've manually used argyll). Is there any
> reason why this patch hasn't been applied yet? I can imagine that you don't
> consider it the prettiest fix, but it works and shouldn't cause any problems
> for other versions of argyll.

Agreed. I've pushed this to gnome-3-2 and master.