After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631771 - Verify base64 data has '=' end-markers
Verify base64 data has '=' end-markers
Status: RESOLVED OBSOLETE
Product: sysadmin
Classification: Infrastructure
Component: Mango (obsolete)
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2010-10-09 18:31 UTC by Olav Vitters
Modified: 2013-11-21 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure base64-encoded SSH keys have correct padding (1021 bytes, patch)
2010-10-14 07:26 UTC, Raymond Lu 		none Details | Review

Description Olav Vitters 2010-10-09 18:31:05 UTC 
Mango currently verifies SSH keys by base64 decoding the data and checking if that succeeds.

Seems that PHP allows the '=' end-markers to be left out. This resulted in the key for jralls to be seen as valid and even with the right fingerprint, while SSH would refuse to decode the base64 data.

Solution would be to be strict with the allowed base64 data. Not sure if PHP allows this. Perhaps only to be implemented for the Django version.
Comment 1 Owen Taylor 2010-10-09 18:41:25 UTC 
[ Probably clear, but worth pointing out that the = character represents padding, and depending on the length of the encoded data base64 strings can end with 0, 1, or 2 = signs ]
Comment 2 Raymond Lu 2010-10-14 07:26:57 UTC 
Created attachment 172332 [details] [review]
Ensure base64-encoded SSH keys have correct padding
Comment 3 Raymond Lu 2010-10-18 21:01:15 UTC 
Perhaps it would be better to just base64_encode the decoded string and see if it's the same as the input.
Comment 4 Andrea Veri 2013-11-21 14:55:16 UTC 
The GNOME Infrastructure Team is currently migrating its bug / issue tracker away from Bugzilla to Request Tracker and therefore all the currently open bugs have been closed and marked as OBSOLETE.

The following move will also act as a cleanup for very old and ancient tickets that were still living on Bugzilla. If your issue still hasn't been fixed as of today please report it again on the relevant RT queue.

More details about the available queues you can report the bug against can be found at https://wiki.gnome.org/Sysadmin/RequestTracker.

Thanks for your patience,

the GNOME Infrastructure Team