After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631654 - unable to compile due to a deprecated gtk+ function
unable to compile due to a deprecated gtk+ function
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-08 01:15 UTC by Patrick Deschenes
Modified: 2010-10-23 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove a deprecated gtk+ 3.0 function (951 bytes, patch)
2010-10-08 01:15 UTC, Patrick Deschenes 		none Details | Review

Description Patrick Deschenes 2010-10-08 01:15:09 UTC 
the function `gtk_dialog_set_has_separator` is deprecated in gtk+ 3.0
Comment 1 Patrick Deschenes 2010-10-08 01:15:46 UTC 
Created attachment 171932 [details] [review]
remove a deprecated gtk+ 3.0 function
Comment 2 jessevdk@gmail.com 2010-10-09 15:23:01 UTC 
Thanks, I've pushed it with some small modifications (I made calling it conditional instead of removing it completely).
Comment 3 Patrick Deschenes 2010-10-11 20:05:43 UTC 
I think the condition "#if ! GTK_CHECK_VERSION(2, 91, 0)" is not the good one and I still get the compilation error on my setup with it. Actually, I'm not using gtk+ 3.0 but gtk+2 with "GTK_DISABLE_DEPRECATED" defined by default.

There is only one call to a gtk+ deprecated function and it's this one. I tought that would be a good idea to get rid of it.  Bu if you really want to make it conditional, may I suggest this test instead :

#if (GTK_MAJOR_VERSION < 3) && !GTK_DISABLE_DEPRECATED
Comment 4 jessevdk@gmail.com 2010-10-23 11:59:34 UTC 
I've changed it to ! GTK_CHECK_VERSION (2, 22, 0) which I think should be fine