After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631653 - gjs-console wrapper does not quote $@, breaking -c usage
gjs-console wrapper does not quote $@, breaking -c usage
Status: RESOLVED INVALID
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-08 01:08 UTC by Delan Azabani
Modified: 2010-10-08 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for /usr/bin/gjs-console (84 bytes, patch)
2010-10-08 01:08 UTC, Delan Azabani
none Details | Review

Description Delan Azabani 2010-10-08 01:08:43 UTC
Created attachment 171930 [details] [review]
patch for /usr/bin/gjs-console

gjs-console runs gjs-console.real, but on line 28:

    exec /usr/bin/gjs-console.real $@

should be:

    exec /usr/bin/gjs-console.real "$@"

Without the quotes, it makes it so that if you run:

    gjs-console -c "commands with spaces"

it (wrongly) turns into:

    gjs-console.real -c commands with spaces

but with the patch, will run:

    gjs-console.real -c "commands with spaces"

This bug breaks gnome-shell-clock-preferences.
Comment 1 Micah Gersten 2010-10-08 03:26:31 UTC
This is Ubuntu specific, this can be closed.
Comment 2 Delan Azabani 2010-10-08 03:36:20 UTC
You mean, this problem doesn't exist in Gnome?
Comment 3 Delan Azabani 2010-10-08 03:38:29 UTC
Ah, an Ubuntu-specific wrapper.