After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631588 - Sort by Subject doesn't work
Sort by Subject doesn't work
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-10-07 07:55 UTC by Milan Crha
Modified: 2010-10-07 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (854 bytes, patch)
2010-10-07 08:00 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2010-10-07 07:55:58 UTC
Forwarding this from the downstream bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=640327

Simply sorting by subject doesn't sort messages by it. The downstream bug report contains also screenshots.
Comment 1 Milan Crha 2010-10-07 08:00:05 UTC
Created attachment 171882 [details] [review]
evo patch

for evolution;

The subject sorting used COL_SUBJECT_NORM as a text for comparison, which is simply subject without any leading "Re:" and spaces. The thing is it returned a collation key, not the string itself, but the table had set a sorting which did collate again, on the collation key, thus the comparison was incorrect.

Telling the ETable that the comparison should be simple strcmp fixes the issue.
Comment 2 Milan Crha 2010-10-07 08:05:45 UTC
Created commit 2d0af11 in evo master (2.91.1+)
Created commit 294dd91 in evo gnome-2-32 (2.32.1+)
Comment 3 Waren Sturm 2010-10-07 14:07:48 UTC
That appears to have done the trick.

Thanks