After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631572 - Fix build with GTK+ 2.22
Fix build with GTK+ 2.22
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: build
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-07 03:01 UTC by clark.anthony.g
Modified: 2010-11-04 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
full makepkg log for archlinux (11.65 KB, text/plain)
2010-10-07 03:01 UTC, clark.anthony.g
  Details
config.log (151.36 KB, text/plain)
2010-10-07 13:16 UTC, clark.anthony.g
  Details
Fix for the bug. (856 bytes, patch)
2010-10-09 14:20 UTC, Aurimas Černius
accepted-commit_now Details | Review

Description clark.anthony.g 2010-10-07 03:01:17 UTC
Created attachment 171872 [details]
full makepkg log for archlinux

I've tried building Gnote 0.7.2 on multiple linux boxes with the same result.
Below is the 'tail' on my compilation on archlinux(up to date)

-------
Making all in data
Making all in icons
Generating and caching the translation database
Merging translations into gnote.desktop.
Found cached translation database
Merging translations into gnote.schemas.
Found cached translation database
Merging translations into GNOME_GnoteApplet.server.
Making all in libtomboy
  CC    libtomboy_la-tomboykeybinder.o
tomboykeybinder.c: In function ‘tomboy_keybinder_is_modifier’:
tomboykeybinder.c:316:36: error: ‘gdk_display’ undeclared (first use in this function)
tomboykeybinder.c:316:36: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [libtomboy_la-tomboykeybinder.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
    Aborting...
==> ERROR: Makepkg was unable to build gnote-lite.
==> Restart building gnote-lite ? [y/N]
==> -----------------------------------
==> 
==> WARNING: Following packages have not been installed:
    gnote

--------


** The above is specific output to 'pacman' in archlinux, but the EXACT issue occurs when i ./configure and make the source directly.

I am ALMOST positive that this is a bug with 0.7.2.
Comment 1 Hubert Figuiere (:hub) 2010-10-07 06:07:59 UTC
Which version of Gtk do you use?
Comment 2 clark.anthony.g 2010-10-07 06:23:36 UTC
gtk 1.2.10-10
gtk2 2.22.0-2
Comment 3 Hubert Figuiere (:hub) 2010-10-07 06:35:20 UTC
Can you attach the config.log generated by configure?
Comment 4 clark.anthony.g 2010-10-07 13:16:09 UTC
Created attachment 171892 [details]
config.log
Comment 5 Aurimas Černius 2010-10-09 14:20:37 UTC
Created attachment 172016 [details] [review]
Fix for the bug.

With this patch applied it builds fine for me with both GTK+ 2.20 and 2.22.
Comment 6 Hubert Figuiere (:hub) 2010-10-14 15:39:53 UTC
Comment on attachment 172016 [details] [review]
Fix for the bug.

please commit this
Comment 7 Aurimas Černius 2010-10-14 17:51:06 UTC
Fixed in git master.