After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631566 - Add the banner to the body if the notification is expandable because it has an action area
Add the banner to the body if the notification is expandable because it has a...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 631565 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-06 21:39 UTC by Marina Zhurakhinskaya
Modified: 2010-10-07 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add the banner to the body if the notification is expandable because it has an action area (1.23 KB, patch)
2010-10-06 21:39 UTC, Marina Zhurakhinskaya 		committed Details | Review

Description Marina Zhurakhinskaya 2010-10-06 21:39:53 UTC 
This fixes the bug when the body would be missing from the expanded notification
that has a short body that used to fit in the one-line banner and is expandable
because it has action buttons.

We always want to add the banner to the body of an expandable notification,
unless the notification has custom content. We used to only do that when
creating this._scrollArea for the content. We should also do that when creating
this._actionArea .
Comment 1 Marina Zhurakhinskaya 2010-10-06 21:39:55 UTC 
Created attachment 171856 [details] [review]
Add the banner to the body if the notification is expandable because it has an action area
Comment 2 Marina Zhurakhinskaya 2010-10-06 21:45:23 UTC 
Comment on attachment 171856 [details] [review]
Add the banner to the body if the notification is expandable because it has an action area

Approved by Dan on IRC.
Comment 3 Frederic Peters 2010-10-07 06:55:22 UTC 
*** Bug 631565 has been marked as a duplicate of this bug. ***